Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added point in time support and the Search.iterate() method #1833

Merged
merged 3 commits into from
May 30, 2024

Conversation

miguelgrinberg
Copy link
Collaborator

@miguelgrinberg miguelgrinberg commented May 23, 2024

This change adds two new methods to the Search class. The point_in_time() method and iterate(), to combine point_in_time() with search_after() to provide a better option to scan().

@miguelgrinberg miguelgrinberg force-pushed the pit-and-iterate branch 2 times, most recently from 92e5195 to 650ad7d Compare May 23, 2024 18:32
@miguelgrinberg miguelgrinberg marked this pull request as ready for review May 23, 2024 19:07
@miguelgrinberg miguelgrinberg requested a review from pquentin May 23, 2024 19:09
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

elasticsearch_dsl/_async/search.py Outdated Show resolved Hide resolved
elasticsearch_dsl/_async/search.py Outdated Show resolved Hide resolved
miguelgrinberg and others added 2 commits May 29, 2024 15:01
Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com>
@miguelgrinberg miguelgrinberg merged commit 4a9d882 into elastic:main May 30, 2024
16 checks passed
@miguelgrinberg miguelgrinberg deleted the pit-and-iterate branch May 30, 2024 17:51
@miguelgrinberg miguelgrinberg added the backport 8.x Backport to 8.x label May 30, 2024
github-actions bot pushed a commit that referenced this pull request May 30, 2024
* Added point in time support and the Search.iterate() method

* Update elasticsearch_dsl/_async/search.py

Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com>

* feedback

---------

Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com>
(cherry picked from commit 4a9d882)
miguelgrinberg added a commit that referenced this pull request May 30, 2024
…1834)

* Added point in time support and the Search.iterate() method

* Update elasticsearch_dsl/_async/search.py

Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com>

* feedback

---------

Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com>
(cherry picked from commit 4a9d882)

Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 8.x Backport to 8.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants