Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing serverless client #922

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Removing serverless client #922

merged 3 commits into from
Dec 18, 2024

Conversation

l-trotta
Copy link
Contributor

First commit deleting the module, second commit regenerating after the generator changes

@l-trotta l-trotta requested a review from swallez December 17, 2024 17:56
Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Left a comment about a comment (😱 recursive comment).

@@ -279,6 +279,9 @@ public void testContainerWithOptionalVariants() {
assertEquals(FunctionScore.Kind.Linear, fsq2.functionScore().functions().get(0)._kind());
assertEquals(1.0, fsq2.functionScore().functions().get(0).weight(), 0.001);
assertEquals(2.0, fsq2.functionScore().functions().get(0).linear().untyped().placement().decay(), 0.001);

// possible infinite recursion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Contributor Author

@l-trotta l-trotta Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refuse from tests, sorry o.o

@l-trotta l-trotta merged commit bb6ac88 into main Dec 18, 2024
7 checks passed
@l-trotta l-trotta deleted the removing-serverless-client branch December 18, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants