Port Differ to console application #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ports the Differ F# script over to a console
application, and includes a number of improvements:
- Correct resolution of NuGet references respective to target framework
- Ability to diff any two assembly providers e.g.
compare NuGet package to the build of a GitHub commit
compare loacl assembly to NuGet package, etc.
Closes elastic/elasticsearch-net#3305
Mpdreamz
approved these changes
Sep 5, 2018
There was a problem hiding this comment.
LGTM ;+1: afaik this also complies with ASL2.0
https://tldrlegal.com/license/apache-license-2.0-(apache-2.0)
The source project https://github.com/telerik/JustAssembly does not contain a NOTICE file.
Perhaps note the license and JustAssemly dependency in the README?
|
After this PR we'll need to add it to the build scripts. |
89 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ports the Differ F# script over to a console
application, and includes a number of improvements:
compare NuGet package to the build of a GitHub commit
compare local assembly to NuGet package, etc.
Closes elastic/elasticsearch-net#3305