Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose BulkResponseItems on BulkAllResponse #3598

Merged
merged 1 commit into from
Mar 15, 2019
Merged

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Mar 13, 2019

This commit exposes the bulk response items on the BulkAllResponse.

Closes #3487

This commit exposes the bulk response items on the BulkAllResponse.

Closes #3487
Copy link
Contributor

@codebrain codebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -185,7 +194,7 @@ private async Task<IBulkAllResponse> HandleBulkRequest(IList<T> buffer, long pag
throw ThrowOnBadBulk(response,
$"BulkAll halted after {nameof(PipelineFailure)}{failureReason.GetStringValue()} from _bulk");
default:
return await RetryDocuments(page, ++backOffRetries, buffer);
return await RetryDocuments(page, ++backOffRetries, buffer).ConfigureAwait(false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@russcam russcam merged commit 25226cc into 6.6 Mar 15, 2019
russcam added a commit that referenced this pull request Mar 20, 2019
This commit exposes the bulk response items on the BulkAllResponse.

Closes #3487
russcam added a commit that referenced this pull request Mar 21, 2019
This commit exposes the bulk response items on the BulkAllResponse.

Closes #3487
@russcam russcam deleted the feature/bulk-all-ids branch March 27, 2019 03:40
russcam added a commit that referenced this pull request Apr 2, 2019
This commit exposes the bulk response items on the BulkAllResponse.

Closes #3487

(cherry picked from commit 41eba8c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants