Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security API changes to add owner flag #4178

Merged
merged 3 commits into from
Nov 12, 2019

Conversation

codebrain
Copy link
Contributor

@codebrain codebrain mentioned this pull request Oct 25, 2019
39 tasks
@codebrain codebrain requested a review from russcam October 29, 2019 05:15
@Mpdreamz
Copy link
Member

[xUnit.net 00:07:57.4773251]     Tests.Indices.IndexManagement.SplitIndex.SplitIndexApiTests.ReturnsExpectedResponse [FAIL]
[2019-10-25T01:31:22,987][INFO ][o.e.c.m.MetaDataCreateIndexService] [writable-node-dbf2af9200] [test-ngramtests-initializerasync-ffeefa61] creating index, cause [api], templates [nest_tests], shards [2]/[0], mappings []
[2019-10-25T01:31:23,315][INFO ][o.e.c.m.MetaDataCreateIndexService] [writable-node-dbf2af9200] [nest-fluent-024f6b2e_clone] creating index, cause [clone_index], templates [], shards [1]/[0], mappings []
[2019-10-25T01:31:23,488][INFO ][o.e.c.m.MetaDataCreateIndexService] [writable-node-dbf2af9200] [nest-fluent-6e9833a8-1] creating index, cause [api], templates [nest_tests], shards [2]/[0], mappings []
  X Tests.Indices.IndexManagement.SplitIndex.SplitIndexApiTests.ReturnsExpectedResponse [901ms]
  Error Message:
   Tests.Framework.EndpointTests.ResponseAssertionException : Expected response.ShardsAcknowledged to be true, but found False.
Response Under Test:
Valid NEST response built from a successful (200) low level call on PUT: /nest-initializer-485aa104/_split/nest-initializer-485aa104-target?pretty=true&error_trace=true
# Audit trail of this API call:
 - [1] HealthyResponse: Node: http://localhost:9200/ Took: 00:00:30.6478671
# Request:
{"settings":{"index.number_of_shards":8}}
# Response:
{
  "acknowledged" : true,
  "shards_acknowledged" : false,
  "index" : "nest-initializer-485aa104-target"
}

shards_acknowledged is likely to stay flakey as we do a ridiculous amount of cluster updates.

@codebrain codebrain merged commit 633d7b6 into 7.x Nov 12, 2019
codebrain added a commit that referenced this pull request Nov 12, 2019
@codebrain
Copy link
Contributor Author

Ported to master

@codebrain
Copy link
Contributor Author

Ported to 7.4

@russcam russcam deleted the feature/7.4.1/authentication-owner branch February 23, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants