-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SearchHitIterators and SearchResponseIterator helpers revised with new version #1302
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jenkins test this please |
I think the tests will be broken because of phpstan. 🥹 I could not find a way to ignore with comment or put that methods into interface. |
I ignored the lines from PHPStan. But, the test is broken again because of another reason. |
Ping @ezimuel |
I could not understand the tests that throw errors. As I remember, we got the same error before.
|
…nside the interface
009e28f
to
9efbbca
Compare
Thanks @hkulekci for the PR and sorry for the late reply. |
Thanks for merging 🕺 |
We have problems related to the PHPStan check. I had already mentioned in issue #1301