Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[src] add PHP_CodeSniffer #647

Merged
merged 3 commits into from
Nov 7, 2017
Merged

[src] add PHP_CodeSniffer #647

merged 3 commits into from
Nov 7, 2017

Conversation

mhujer
Copy link
Contributor

@mhujer mhujer commented Sep 14, 2017

This PR fixes PSR-2 violations in src and adds automatic check as a part of the build.

Depends on #638 (it should be merged first)

@polyfractal
Copy link
Contributor

Looks like this is the next PR in the chain of dependencies?

@mhujer
Copy link
Contributor Author

mhujer commented Nov 7, 2017

@polyfractal Just rebased it.

@polyfractal polyfractal merged commit 95a2c32 into elastic:master Nov 7, 2017
@polyfractal
Copy link
Contributor

emot-toot

@mhujer mhujer deleted the mh-phpcs branch November 7, 2017 19:48
polyfractal pushed a commit that referenced this pull request Nov 14, 2017
* PSR-2 fixes (auto)

* PSR-2 manual exclude

* PSR-2 check as a part of build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants