Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan refactor #924

Merged
merged 4 commits into from
Apr 5, 2019
Merged

Scan refactor #924

merged 4 commits into from
Apr 5, 2019

Conversation

0bsearch
Copy link
Contributor

@0bsearch 0bsearch commented Apr 4, 2019

Since scan search-type is deprecated since 2.1, there's simpler implementation for scan logic.

Also adds tests for scan-related stuff

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@fxdgear
Copy link
Contributor

fxdgear commented Apr 4, 2019

jenkins test this please

@0bsearch
Copy link
Contributor Author

0bsearch commented Apr 5, 2019

Side note on this: for next major release I propose to change this one step further — let's make error-handling run before yielding results. This will not affect case with raise_on_error=False, but will introduce fast exit route for raise_on_error=True. IMO, raising exception as soon as we see problem in response makes more sense that yielding batch of results first.

@fxdgear fxdgear merged commit 2181611 into elastic:master Apr 5, 2019
@fxdgear
Copy link
Contributor

fxdgear commented Apr 5, 2019

i've yet to do the 7.x release, so if you want to do that now feel free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants