Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MODEL] Refactor module/mixin organization for clarity #893

Merged
merged 3 commits into from
Jul 26, 2019
Merged

[MODEL] Refactor module/mixin organization for clarity #893

merged 3 commits into from
Jul 26, 2019

Conversation

estolfo
Copy link
Contributor

@estolfo estolfo commented Jul 24, 2019

No description provided.

@estolfo estolfo changed the title [MODEL] Refactor module inclusion for clarity [MODEL] Refactor module/mixin organization for clarity Jul 26, 2019
@estolfo estolfo merged commit f9a87ff into elastic:master Jul 26, 2019
@lulalala
Copy link
Contributor

lulalala commented Jan 15, 2020 •
edited
Loading

A delayed appreciation for turning the dynamic module includes during included block to a static one! It took me awhile in my head to get around how module includes worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estolfo @lulalala