Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP Gem support #25

Closed
ixti opened this issue Jan 20, 2014 · 10 comments
Closed

HTTP Gem support #25

ixti opened this issue Jan 20, 2014 · 10 comments

Comments

@ixti
Copy link

ixti commented Jan 20, 2014

Will you consider accepting PR with new transport adapter The HTTP Gem?
@ixti
Copy link
Author

ixti commented Jan 21, 2014

I would provide one, but just don't wanna spend time if it's not gonna be accepted due to "no more new adapters are allowed".

@karmi
Copy link
Contributor

karmi commented Jan 21, 2014

just don't wanna spend time if it's not gonna be accepted

Aleksey, I can't evaluate a "future pull request".

In general, there's nothing which prevents Faraday non-compatible HTTP libraries to be added.

@ixti
Copy link
Author

ixti commented Jan 21, 2014

In general, there's nothing which prevents Faraday non-compatible HTTP libraries to be added.

That's what I wanted to know :D Will open a pull request then, once it's ready.

@ixti ixti closed this as completed Jan 21, 2014
@karmi
Copy link
Contributor

karmi commented Feb 16, 2014

BTW, it would be cool if the HTTP gem could provide a Faraday adapter -- then the support would come basically for free...

@ixti
Copy link
Author

ixti commented Feb 16, 2014

@karmi Yeah. There were some talking about Faraday adapter. Although, I believe it would be better to have a direct HTTP Gem transport:

Twitter test suite (about 900 examples that make about 368 HTTP requests) runs about 4X faster in the http branch than in master (with Faraday)
httprb/http#73 (comment)

@karmi
Copy link
Contributor

karmi commented Feb 17, 2014

Sounds like quite a difference! The integration can well be done like the Curb one, via special "transport class" -- the contract of the class is quite minimal and well documented in unit/integration tests.

@ixti
Copy link
Author

ixti commented Feb 17, 2014

Yeah, I already looked on specs of Curb adapter. I'm just little bit busy at the moment, and HTP gem also is at stage of final changes before 0.6.0 release (last one before 1.0.0). So once 0.6.0 is out there I'll prepare a PR for this adapter :D

@karmi
Copy link
Contributor

karmi commented Feb 17, 2014

Cool. Just send the pull request when it's ready, and let's close this ticket until then? Please reference this ticket in the new pull request, so we don't lose track of conversations.

BTW, try to persuade tarcieri to add a Faraday adapter, even though it's slower -- it's realy beneficial to the whole ecosystem.

@ixti
Copy link
Author

ixti commented Feb 17, 2014

I have already closed this ticket a month ago: #25 (comment)

I will try to persuade Tony or will implement it myself :D

@karmi
Copy link
Contributor

karmi commented Feb 17, 2014

@ixti Err, sorry. Too much tickets in too much repositories :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karmi @ixti