Skip to content

Commit

Permalink
Remove stale comment from JVM stats (#29625)
Browse files Browse the repository at this point in the history
We removed catched throwable from the code base and left behind was a
comment about catching InternalError in MemoryManagementMXBean. We are
not going to catch InternalError here as we expect that to be
fatal. This commit removes that stale comment.
  • Loading branch information
jasontedor committed Apr 19, 2018
1 parent 691af11 commit 6d2d509
Showing 1 changed file with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,8 @@ public static JvmStats jvmStats() {
peakUsage.getUsed() < 0 ? 0 : peakUsage.getUsed(),
peakUsage.getMax() < 0 ? 0 : peakUsage.getMax()
));
} catch (Exception ex) {
/* ignore some JVMs might barf here with:
* java.lang.InternalError: Memory Pool not found
* we just omit the pool in that case!*/
} catch (final Exception ignored) {

}
}
Mem mem = new Mem(heapCommitted, heapUsed, heapMax, nonHeapCommitted, nonHeapUsed, Collections.unmodifiableList(pools));
Expand Down

0 comments on commit 6d2d509

Please sign in to comment.