Forbid negative values for index.unassigned.node_left.delayed_timeout (…

…#26828) Change delayed_timeout to be a positiveTimeSetting, and add note that this is a breaking change
elastic · Sep 29, 2017 · 8fe9a20 · 8fe9a20
1 parent 1715fd7
commit 8fe9a20
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/core/src/main/java/org/elasticsearch/cluster/routing/UnassignedInfo.java b/core/src/main/java/org/elasticsearch/cluster/routing/UnassignedInfo.java
@@ -50,7 +50,7 @@ public final class UnassignedInfo implements ToXContentFragment, Writeable {
     public static final FormatDateTimeFormatter DATE_TIME_FORMATTER = Joda.forPattern("dateOptionalTime");
 
     public static final Setting<TimeValue> INDEX_DELAYED_NODE_LEFT_TIMEOUT_SETTING =
-        Setting.timeSetting("index.unassigned.node_left.delayed_timeout", TimeValue.timeValueMinutes(1), Property.Dynamic,
+        Setting.positiveTimeSetting("index.unassigned.node_left.delayed_timeout", TimeValue.timeValueMinutes(1), Property.Dynamic,
             Property.IndexScope);
     /**
      * Reason why the shard is in unassigned state.

diff --git a/docs/reference/migration/migrate_7_0/indices.asciidoc b/docs/reference/migration/migrate_7_0/indices.asciidoc
@@ -5,3 +5,8 @@
 
 Due to cross-cluster search using `:` to separate a cluster and index name,
 index names may no longer contain `:`.
+
+==== `index.unassigned.node_left.delayed_timeout` may no longer be negative
+
+Negative values were interpreted as zero in earlier versions but are no
+longer accepted.