Skip to content

Commit

Permalink
[ML] Re-enable memory limit integration tests (#31328)
Browse files Browse the repository at this point in the history
  • Loading branch information
tveasey authored Jul 12, 2018
1 parent 30d6fd3 commit de2eb85
Showing 1 changed file with 1 addition and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ public void cleanUpTest() {
cleanUp();
}

@AwaitsFix(bugUrl = "https://github.com/elastic/ml-cpp/pulls/122")
public void testTooManyPartitions() throws Exception {
Detector.Builder detector = new Detector.Builder("count", null);
detector.setPartitionFieldName("user");
Expand All @@ -63,7 +62,7 @@ public void testTooManyPartitions() throws Exception {
long timestamp = now - 8 * bucketSpan.seconds();
List<String> data = new ArrayList<>();
while (timestamp < now) {
for (int i = 0; i < 10000; i++) {
for (int i = 0; i < 11000; i++) {
// It's important that the values used here are either always represented in less than 16 UTF-8 bytes or
// always represented in more than 22 UTF-8 bytes. Otherwise platform differences in when the small string
// optimisation is used will make the results of this test very different for the different platforms.
Expand All @@ -83,7 +82,6 @@ public void testTooManyPartitions() throws Exception {
assertThat(modelSizeStats.getMemoryStatus(), equalTo(ModelSizeStats.MemoryStatus.HARD_LIMIT));
}

@AwaitsFix(bugUrl = "https://github.com/elastic/ml-cpp/pulls/122")
public void testTooManyByFields() throws Exception {
Detector.Builder detector = new Detector.Builder("count", null);
detector.setByFieldName("user");
Expand Down Expand Up @@ -129,7 +127,6 @@ public void testTooManyByFields() throws Exception {
assertThat(modelSizeStats.getMemoryStatus(), equalTo(ModelSizeStats.MemoryStatus.HARD_LIMIT));
}

@AwaitsFix(bugUrl = "https://github.com/elastic/ml-cpp/pulls/122")
public void testTooManyByAndOverFields() throws Exception {
Detector.Builder detector = new Detector.Builder("count", null);
detector.setByFieldName("department");
Expand Down Expand Up @@ -179,7 +176,6 @@ public void testTooManyByAndOverFields() throws Exception {
assertThat(modelSizeStats.getMemoryStatus(), equalTo(ModelSizeStats.MemoryStatus.HARD_LIMIT));
}

@AwaitsFix(bugUrl = "https://github.com/elastic/ml-cpp/pulls/122")
public void testManyDistinctOverFields() throws Exception {
Detector.Builder detector = new Detector.Builder("sum", "value");
detector.setOverFieldName("user");
Expand Down

0 comments on commit de2eb85

Please sign in to comment.