Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate replication:async #10114

Closed
clintongormley opened this issue Mar 16, 2015 · 10 comments · Fixed by #10171
Closed

Deprecate replication:async #10114

clintongormley opened this issue Mar 16, 2015 · 10 comments · Fixed by #10171
Labels
:Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >enhancement v1.5.0

Comments

@clintongormley
Copy link

Async replication clashes with index sealing (#10032). Another downside of async replication is that clients cannot be sure that changes have reached the replica. The benefits of async replication can be achieved simply by having more clients (threads or forks).

Let's deprecate this in 1.5
@clintongormley clintongormley added >enhancement v1.5.0 :Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. labels Mar 16, 2015
@dakrone
Copy link
Member

dakrone commented Mar 16, 2015

+1 to deprecate in 1.5, remove in 2.0

@rjernst
Copy link
Member

rjernst commented Mar 16, 2015

+1

1 similar comment
@s1monw
Copy link
Contributor

s1monw commented Mar 17, 2015

+1

@s1monw
Copy link
Contributor

s1monw commented Mar 18, 2015

@clintongormley can you deprecate it in the docs please for 1.5

@clintongormley clintongormley mentioned this issue Mar 19, 2015
Merged
clintongormley added a commit that referenced this issue Mar 19, 2015
@clintongormley
Deprecate async replication
0cb1504 
Doc changes to deprecate async replication in 1.5.0 and 1.x

Relates to #10114
@clintongormley clintongormley mentioned this issue Mar 19, 2015
Merged
@clintongormley
Copy link
Author

Deprecated in the docs for 1.5.0, and removed from the docs and REST spec in 2.0.

Still needs to be removed in the code.

rmuir pushed a commit to rmuir/elasticsearch that referenced this issue Mar 19, 2015
@clintongormley @rmuir
Remove async replication from the docs and REST spec
b05b803 
Relates to elastic#10114
@s1monw s1monw mentioned this issue Mar 19, 2015
Merged
s1monw added a commit to s1monw/elasticsearch that referenced this issue Mar 19, 2015
@s1monw
[REPLICATION] Remove async replication
1168347 
Closes elastic#10114
@dadoonet
Copy link
Member

Just a note here. It sounds like we deprecated this in docs but we did not add @Deprecated annotation in elasticsearch code itself. Should we add it so Java developers would be aware of it when compiling their code?

@javanna
Copy link
Member

javanna commented Mar 31, 2015

Yes I think we should @dadoonet , can you open an issue or even take care of this with a PR against 1.x?

dadoonet added a commit to elastic/elasticsearch-river-rabbitmq that referenced this issue Mar 31, 2015
@dadoonet
Deprecate replication parameter
fc3f394 
`replication:async` has been deprecated in elasticsearch 1.5.0 and removed in master (2.0.0). See elastic/elasticsearch#10114.

We need to do the same in RabbitMQ river plugin.

Closes #91.
dadoonet added a commit to elastic/elasticsearch-river-rabbitmq that referenced this issue Mar 31, 2015
@dadoonet
Deprecate replication parameter
0346d1c 
`replication:async` has been deprecated in elasticsearch 1.5.0 and removed in master (2.0.0). See elastic/elasticsearch#10114.

We need to do the same in RabbitMQ river plugin.

Closes #91.
(cherry picked from commit fc3f394)
(cherry picked from commit 1df982b)
dadoonet added a commit to elastic/elasticsearch-river-rabbitmq that referenced this issue Mar 31, 2015
@dadoonet
Deprecate replication parameter
1df982b 
`replication:async` has been deprecated in elasticsearch 1.5.0 and removed in master (2.0.0). See elastic/elasticsearch#10114.

We need to do the same in RabbitMQ river plugin.

Closes #91.
(cherry picked from commit fc3f394)
dadoonet added a commit to dadoonet/elasticsearch that referenced this issue Apr 17, 2015
@dadoonet
[java] Remove async replication
d61f0d2 
Follow up for PR elastic#10171.

As we discussed elastic#10114 (comment), we should also mark the code as deprecated so plugin developers know in advance that they need to adapt their code.

I also added a `log` when using `replication` parameter in REST APIs but as `info` Level. I wonder if I should better log that as a `WARN` if `debug` level is set? So people in debug mode will see this information as a `WARN` while it won't pollute logs for each call when in default `INFO` log level.
@dadoonet dadoonet mentioned this issue Apr 17, 2015
Closed
@jordansissel jordansissel mentioned this issue May 16, 2015
Closed
dadoonet added a commit to dadoonet/elasticsearch that referenced this issue May 29, 2015
@dadoonet
[java] Deprecate async replication in java API
cbd2b6c 
Follow up for PR elastic#10171.

As we discussed elastic#10114 (comment), we should also mark the code as deprecated so plugin developers know in advance that they need to adapt their code.
dadoonet added a commit to dadoonet/elasticsearch that referenced this issue May 29, 2015
@dadoonet
[java] Deprecate async replication in java API
f2ed5d1 
Follow up for PR elastic#10171.

As we discussed elastic#10114 (comment), we should also mark the code as deprecated so plugin developers know in advance that they need to adapt their code.
dadoonet added a commit to dadoonet/elasticsearch that referenced this issue May 29, 2015
@dadoonet
[java] Deprecate async replication in java API
1493cfb 
Follow up for PR elastic#10171.

As we discussed elastic#10114 (comment), we should also mark the code as deprecated so plugin developers know in advance that they need to adapt their code.
dadoonet added a commit that referenced this issue May 29, 2015
@dadoonet
[java] Deprecate async replication in java API
d9561e3 
Follow up for PR #10171.

As we discussed #10114 (comment), we should also mark the code as deprecated so plugin developers know in advance that they need to adapt their code.
joschi pushed a commit to Graylog2/graylog2-server that referenced this issue Jul 6, 2015
Use synchronous replication (default) for bulk indexing
61f091b 
Asynchronous replication will be removed in Elasticsearch 2.0. (elastic/elasticsearch#10114)

Closes #1264
@joschi joschi mentioned this issue Jul 6, 2015
Merged
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@clintongormley
Deprecate async replication
ad86815 
Doc changes to deprecate async replication in 1.5.0 and 1.x

Relates to elastic#10114
@fsaravia
Copy link

fsaravia commented Oct 7, 2015

Hey everyone, does this document needs to be updated to state that async replication has been deprecated? The document has a replication section that talks about sync and async options.

@clintongormley
Copy link
Author

@fsaravia the Guide targets ES 1.4. Yes, it does need a big update for 2.0... i know, i know

@fsaravia
Copy link

fsaravia commented Oct 8, 2015

@clintongormley oh, sorry about that. I didn't realize it targets ES 1.4 :)

luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
Use synchronous replication (default) for bulk indexing
60ee400 
    Asynchronous replication will be removed in Elasticsearch 2.0. (elastic/elasticsearch#10114)

    Closes #1264
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >enhancement v1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove async replication s1monw/elasticsearch
7 participants
@dakrone @clintongormley @dadoonet @rjernst @javanna @fsaravia @s1monw