You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the moment, you have fromInclusive and toInclusive, but defaulting to true.
It feels unintuitive to pass an option that is false ie if something isn't specified, then to me it is the same as false, but then you enable an action by passing a true.
So I'd change the options to exclude_from or exclude_to, which default to false
Alternatively, you could change the from and to options themselves, eg:
param equivalent to:
-------------------------------------
from: fromInclusive = true
to: toInclusive = true
greater_than: fromInclusive = false
less_than: toInclusive = false
The Perl string comparison operators are gt, lt, gte (greater than or equals) and lte, but that may be a step too far :)
The text was updated successfully, but these errors were encountered:
At the moment, you have
fromInclusive
andtoInclusive
, but defaulting totrue
.It feels unintuitive to pass an option that is false ie if something isn't specified, then to me it is the same as false, but then you enable an action by passing a true.
So I'd change the options to
exclude_from
orexclude_to
, which default tofalse
Alternatively, you could change the
from
andto
options themselves, eg:The Perl string comparison operators are
gt
,lt
,gte
(greater than or equals) andlte
, but that may be a step too far :)The text was updated successfully, but these errors were encountered: