Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Change: Terms - Add support for gt/gte/lt/lte #108

Closed
clintongormley opened this issue Apr 4, 2010 · 1 comment
Closed

API Change: Terms - Add support for gt/gte/lt/lte #108

clintongormley opened this issue Apr 4, 2010 · 1 comment

Comments

@clintongormley
Copy link

At the moment, you have fromInclusive and toInclusive, but defaulting to true.

It feels unintuitive to pass an option that is false ie if something isn't specified, then to me it is the same as false, but then you enable an action by passing a true.

So I'd change the options to exclude_from or exclude_to, which default to false

Alternatively, you could change the from and to options themselves, eg:

param              equivalent to:
-------------------------------------
from:              fromInclusive = true
to:                toInclusive   = true
greater_than:      fromInclusive = false
less_than:         toInclusive   = false

The Perl string comparison operators are gt, lt, gte (greater than or equals) and lte, but that may be a step too far :)

@kimchy
Copy link
Member

kimchy commented Apr 4, 2010

API Change: Terms - Add support for gt/gte/lt/lte, closed by 33086fb.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants