Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] RepositoryVerifyIntegrityIT testTransportException failing #112779

Closed
elasticsearchmachine opened this issue Sep 12, 2024 · 2 comments · Fixed by #112780
Closed

[CI] RepositoryVerifyIntegrityIT testTransportException failing #112779

elasticsearchmachine opened this issue Sep 12, 2024 · 2 comments · Fixed by #112780
Assignees
@ywangd
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs low-risk An open issue or test failure that is a low risk to future releases Team:Distributed Meta label for distributed team (obsolete) >test-failure Triaged test failures from CI

Comments

@elasticsearchmachine
Copy link
Collaborator

Build Scans:

Reproduction Line:

./gradlew ":x-pack:plugin:snapshot-repo-test-kit:internalClusterTest" --tests "org.elasticsearch.repositories.blobstore.testkit.integrity.RepositoryVerifyIntegrityIT.testTransportException" -Dtests.seed=4B676F2F3738A1A3 -Dtests.locale=gsw-LI -Dtests.timezone=Australia/Adelaide -Druntime.java=22

Applicable branches:
main

Reproduces locally?:
N/A

Failure History:
See dashboard

Failure Message:

java.lang.AssertionError: org.elasticsearch.common.util.CancellableThreads$ExecutionCancelledException: operation was cancelled reason [task cancelled]

Issue Reasons:

  • [main] 2 failures in test testTransportException (2.6% fail rate in 77 executions)

Note:
This issue was created using new test triage automation. Please report issues or feedback to es-delivery.
@elasticsearchmachine elasticsearchmachine added :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test-failure Triaged test failures from CI labels Sep 12, 2024
@elasticsearchmachine
Copy link
Collaborator Author

This has been muted on branch main

Mute Reasons:

  • [main] 2 failures in test testTransportException (2.6% fail rate in 77 executions)

Build Scans:

elasticsearchmachine added a commit that referenced this issue Sep 12, 2024
@elasticsearchmachine
Mute org.elasticsearch.repositories.blobstore.testkit.integrity.Repos…
a8dcce5 
…itoryVerifyIntegrityIT testTransportException #112779
@elasticsearchmachine elasticsearchmachine added Team:Distributed Meta label for distributed team (obsolete) needs:risk Requires assignment of a risk label (low, medium, blocker) labels Sep 12, 2024
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-distributed (Team:Distributed)

@ywangd ywangd self-assigned this Sep 12, 2024
@ywangd ywangd added low-risk An open issue or test failure that is a low risk to future releases and removed needs:risk Requires assignment of a risk label (low, medium, blocker) labels Sep 12, 2024
ywangd added a commit to ywangd/elasticsearch that referenced this issue Sep 12, 2024
@ywangd
Do not throw in task enqueued by CancellableRunner
f686331 
CancellableThreads#eecute can throw runtime exception including
cancellation. This does not work with AbstractThrottledTaskRunner which
expects enqueued task to _not_ throw. This PR catches any runtime
exception from CancellableThreads and hand it back to the original
runnable.

Resolves: elastic#112779
@ywangd ywangd mentioned this issue Sep 12, 2024
Merged
elasticsearchmachine pushed a commit that referenced this issue Sep 12, 2024
@ywangd
Do not throw in task enqueued by CancellableRunner (#112780)
e22bef6 
CancellableThreads#excute can throw runtime exception including
cancellation. This does not work with AbstractThrottledTaskRunner which
expects enqueued task to _not_ throw. This PR catches any runtime
exception from CancellableThreads and hand it back to the original
runnable.

Resolves: #112779
ywangd added a commit to ywangd/elasticsearch that referenced this issue Sep 12, 2024
@ywangd
Do not throw in task enqueued by CancellableRunner (elastic#112780)
ffd4a2e 
CancellableThreads#excute can throw runtime exception including
cancellation. This does not work with AbstractThrottledTaskRunner which
expects enqueued task to _not_ throw. This PR catches any runtime
exception from CancellableThreads and hand it back to the original
runnable.

Resolves: elastic#112779
(cherry picked from commit e22bef6)

# Conflicts:
#	muted-tests.yml
v1v added a commit to v1v/elasticsearch that referenced this issue Sep 12, 2024
@v1v
Merge remote-tracking branch 'upstream/main' into feature/bump-automa…
48c937f 
…tion-ironbank-ubi

* upstream/main: (302 commits)
  Deduplicate BucketOrder when deserializing (elastic#112707)
  Introduce test utils for ingest pipelines (elastic#112733)
  [Test] Account for auto-repairing for shard gen file (elastic#112778)
  Do not throw in task enqueued by CancellableRunner (elastic#112780)
  Mute org.elasticsearch.script.StatsSummaryTests testEqualsAndHashCode elastic#112439
  Mute org.elasticsearch.repositories.blobstore.testkit.integrity.RepositoryVerifyIntegrityIT testTransportException elastic#112779
  Use a dedicated test executor in MockTransportService (elastic#112748)
  Estimate segment field usages (elastic#112760)
  (Doc+) Inference Pipeline ignores Mapping Analyzers (elastic#112522)
  Fix verifyVersions task (elastic#112765)
  (Doc+) Terminating Exit Codes (elastic#112530)
  (Doc+) CAT Nodes default columns (elastic#112715)
  [DOCS] Augment installation warnings (elastic#112756)
  Mute org.elasticsearch.repositories.blobstore.testkit.integrity.RepositoryVerifyIntegrityIT testCorruption elastic#112769
  Bump Elasticsearch to a minimum of JDK 21 (elastic#112252)
  ESQL: Compute support for filtering ungrouped aggs (elastic#112717)
  Bump Elasticsearch version to 9.0.0 (elastic#112570)
  add CDR related data streams to kibana_system priviliges (elastic#112655)
  Support widening of numeric types in union-types (elastic#112610)
  Introduce data stream options and failure store configuration classes (elastic#109515)
  ...
elasticsearchmachine pushed a commit that referenced this issue Sep 12, 2024
@ywangd @elasticmachine
[8.x] Do not throw in task enqueued by CancellableRunner (#112780) (#…
8d87b1c 
…112786)

* Do not throw in task enqueued by CancellableRunner (#112780)

CancellableThreads#excute can throw runtime exception including
cancellation. This does not work with AbstractThrottledTaskRunner which
expects enqueued task to _not_ throw. This PR catches any runtime
exception from CancellableThreads and hand it back to the original
runnable.

Resolves: #112779
(cherry picked from commit e22bef6)

# Conflicts:
#	muted-tests.yml

* Update muted-tests.yml

* Update muted-tests.yml

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
davidkyle pushed a commit that referenced this issue Sep 12, 2024
@elasticsearchmachine @davidkyle
Mute org.elasticsearch.repositories.blobstore.testkit.integrity.Repos…
2046b29 
…itoryVerifyIntegrityIT testTransportException #112779
davidkyle pushed a commit that referenced this issue Sep 12, 2024
@ywangd @davidkyle
Do not throw in task enqueued by CancellableRunner (#112780)
6fdb78c 
CancellableThreads#excute can throw runtime exception including
cancellation. This does not work with AbstractThrottledTaskRunner which
expects enqueued task to _not_ throw. This PR catches any runtime
exception from CancellableThreads and hand it back to the original
runnable.

Resolves: #112779
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ywangd ywangd

Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs low-risk An open issue or test failure that is a low risk to future releases Team:Distributed Meta label for distributed team (obsolete) >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not throw in task enqueued by CancellableRunner ywangd/elasticsearch
2 participants
@ywangd @elasticsearchmachine