Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESQL] Support date nanos on Bucket function #118031

Closed
Tracked by #109352
not-napoleon opened this issue Dec 4, 2024 · 1 comment · Fixed by #118474
Closed
Tracked by #109352

[ESQL] Support date nanos on Bucket function #118031

not-napoleon opened this issue Dec 4, 2024 · 1 comment · Fixed by #118474
Assignees
@not-napoleon
Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@not-napoleon
Copy link
Member

not-napoleon commented Dec 4, 2024 •
edited
Loading

Support bucket function on date nanos type. Bucket is just wrapping date trunc here, which we added support for in #110008, so this should be a pretty small change.
@not-napoleon not-napoleon mentioned this issue Dec 4, 2024
Open
@not-napoleon not-napoleon self-assigned this Dec 4, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Dec 4, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@not-napoleon not-napoleon mentioned this issue Dec 11, 2024
Merged
not-napoleon added a commit to not-napoleon/elasticsearch that referenced this issue Dec 13, 2024
@not-napoleon
Esql bucket function for date nanos (elastic#118474)
82946f8 
This adds support for running the bucket function over a date nanos field. Code wise, this just delegates to DateTrunc, which already supports date nanos, so most of the PR is just tests and the auto-generated docs.

Resolves elastic#118031
elasticsearchmachine pushed a commit that referenced this issue Dec 16, 2024
@not-napoleon
Esql bucket function for date nanos (#118474) (#118670)
9166cd8 
This adds support for running the bucket function over a date nanos field. Code wise, this just delegates to DateTrunc, which already supports date nanos, so most of the PR is just tests and the auto-generated docs.

Resolves #118031
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@not-napoleon not-napoleon

Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Esql bucket function for date nanos not-napoleon/elasticsearch
2 participants
@not-napoleon @elasticsearchmachine