Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests should use pkg private statics on modules to plugin mock implementations #12784

Closed
rjernst opened this issue Aug 10, 2015 · 0 comments · Fixed by #12863
Closed

Tests should use pkg private statics on modules to plugin mock implementations #12784

rjernst opened this issue Aug 10, 2015 · 0 comments · Fixed by #12863
Labels
:Core/Infra/Plugins Plugin API and infrastructure >test Issues or PRs that are addressing/adding tests

Comments

@rjernst
Copy link
Member

rjernst commented Aug 10, 2015

As part of #12744, some tests were changed to plug in mock implementations of classes with regular ES plugins. We should continue this work until all current setting-based-string-classname-loading is removed.
@rjernst rjernst added the >test Issues or PRs that are addressing/adding tests label Aug 10, 2015
@rjernst rjernst mentioned this issue Aug 10, 2015
Merged
@clintongormley clintongormley mentioned this issue Aug 11, 2015
Closed
16 tasks
@clintongormley clintongormley added the :Core/Infra/Plugins Plugin API and infrastructure label Aug 11, 2015
rjernst added a commit to rjernst/elasticsearch that referenced this issue Aug 13, 2015
@rjernst
Tests: Refactor classes only plugged in by tests to use package priva…
ccef055 
…te extension points

We previous used something like Class.forName to load mock classes,
where tests would set a setting that was *supposed* to only be used by
tests. This change make these impls package private so that only tests
can change out these implementations, through test plugins.

closes elastic#12784
@rjernst rjernst mentioned this issue Aug 13, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Core/Infra/Plugins Plugin API and infrastructure >test Issues or PRs that are addressing/adding tests
Projects
None yet
Milestone
No milestone
2 participants
@clintongormley @rjernst