Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for URL Repository #18407

Closed
abeyad opened this issue May 17, 2016 · 2 comments
Closed

Add tests for URL Repository #18407

abeyad opened this issue May 17, 2016 · 2 comments
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs help wanted adoptme >test Issues or PRs that are addressing/adding tests

Comments

@abeyad
Copy link

abeyad commented May 17, 2016 •
edited
Loading

The org.elasticsearch.repositories.uri.URLRepository class does not have any tests written for it. It needs tests to exercise its functionality, probably by connecting it to a webserver, so it will require some thought.

SharedClusterSnapshotRestoreIT contains two tests related to the URL repository:

  1. testUrlRepository
  2. testReadOnlyRepository

However, it would be helpful to have more comprehensive, unit level tests that prove the semantics and guarantees of the URL repository.
@abeyad abeyad added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs labels May 17, 2016
@nik9000
Copy link
Member

nik9000 commented May 17, 2016

We can use a fixture for this I think! See :test:fixtures.

@nik9000 nik9000 added the help wanted adoptme label May 17, 2016
@tlrx
Copy link
Member

tlrx commented Apr 6, 2018

Closed by #29355

@tlrx tlrx closed this as completed Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs help wanted adoptme >test Issues or PRs that are addressing/adding tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nik9000 @tlrx @abeyad