Use fixture to test repository-url module #29355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>test
|
Pinging @elastic/es-distributed |
nik9000
approved these changes
Apr 3, 2018
| @@ -1,3 +1,5 @@ | |||
| import org.elasticsearch.gradle.test.AntFixture | |||
There was a problem hiding this comment.
I'd prefer to have this under the license.
| break; | ||
| } | ||
| } catch (Exception e) { | ||
| logger.debug("Failed to resolve inet address for allowed URL [{}], skipping", allowedUrl); |
There was a problem hiding this comment.
This seems like a pretty bad thing though. maybe we should throw it?
There was a problem hiding this comment.
This is required as the integration tests also declare http://snapshot.test* as an allowed url for some test, so I think we can keep it like this.
| response = new Response(RestStatus.FORBIDDEN, emptyMap(), "text/plain", new byte[0]); | ||
| } | ||
| } else { | ||
| response = new Response(RestStatus.INTERNAL_SERVER_ERROR, emptyMap(), "text/plain", new byte[0]); |
There was a problem hiding this comment.
No "unsupported HTTP method" message? :)
There was a problem hiding this comment.
That's because I'm lazy :) I added the message.
rjernst
approved these changes
Apr 3, 2018
Pursuing the effort to test repository implementations using fixtures, this commit adds a YAML integration test for the repository-url module that uses a fixture to test URL based repositories on both http:// and file:// prefixes.
tlrx
force-pushed
the
add-fixture-for-repository-url
branch
from
89cbd6e to
9a0a65c
Compare
martijnvg
added a commit
that referenced
this pull request
Apr 5, 2018
* es/master: (68 commits) Allow using distance measure in the geo context precision (#29273) Disable failing query in QueryBuilderBWCIT. Fixed quote_field_suffix in query_string (#29332) Use fixture to test repository-url module (#29355) Remove undocumented action.master.force_local setting (#29351) Enhance error for out of bounds byte size settings (#29338) Fix QueryAnalyzerTests. Fix HasChildQueryBuilderTests to not use the `classic` similarity. [Docs] Correct javadoc of GetIndexRequest (#29364) Make TransportRankEvalAction members final Add awaits fix for a query analyzer test Check presence of multi-types before validating new mapping (#29316) Add awaits fix for HasChildQueryBuilderTests Remove silent batch mode from install plugin (#29359) Align cat thread pool info to thread pool config (#29195) Track Lucene operations in engine explicitly (#29357) Build: Fix Java9 MR build (#29312) Reindex: Fix error in delete-by-query rest spec (#29318) Improve similarity integration. (#29187) Fix some query extraction bugs. (#29283) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pursuing the effort to test repository implementations using fixtures, this commit adds a YAML integration test for the
repository-urlmodule that uses a fixture to test URL based repositories on bothhttp://andfile://prefixes.Before running the YAML integration tests, 3 differents repositories are created:
repository-fs
This repository of type
fsis used to create the snapshotsrepository-url
This repository of type
urlis used to test the snapshot restore over HTTP. It uses theurlFixture.repository-file
This repository of type
urlis used to test the snapshot restore using afile://url.