Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently document how to recreate all built in analyzers and test that the docs are right #29499

Closed
nik9000 opened this issue Apr 12, 2018 · 2 comments
Closed

Consistently document how to recreate all built in analyzers and test that the docs are right #29499

nik9000 opened this issue Apr 12, 2018 · 2 comments
Assignees
@nik9000
Labels
>docs General docs changes :Search Relevance/Analysis How text is split into tokens Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests

Comments

@nik9000
Copy link
Member

nik9000 commented Apr 12, 2018

Right now we document how to recreate all of the built in analyzers but we don't test those docs and they aren't 100% consistent. The docs for the language analyzers is all in CONSOLE form but, for example, the keyword analyzer just says that it is made of the keyword tokenizer. While true, it isn't consistent with the language analyzers and isn't tested. I mean, the keyword analyzer is trivial the tests aren't going to find anything, but consistency is nice.
@nik9000 nik9000 added >docs General docs changes >test Issues or PRs that are addressing/adding tests :Search Relevance/Analysis How text is split into tokens labels Apr 12, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@nik9000 nik9000 mentioned this issue Apr 12, 2018
Closed
@nik9000 nik9000 self-assigned this Apr 12, 2018
@nik9000
Copy link
Member Author

nik9000 commented Apr 12, 2018

I'll probably take this because it is more of a docs/test issue then a search-aggs issue. Unless someone wants it more than I do.

@nik9000 nik9000 mentioned this issue Apr 16, 2018
Merged
@nik9000 nik9000 changed the title Consistently document how to recreate all built in indexes and test that the docs are right Consistently document how to recreate all built in analyzers and test that the docs are right May 9, 2018
nik9000 added a commit to nik9000/elasticsearch that referenced this issue May 9, 2018
@nik9000
Docs: Document how to rebuild analyzers
bbae44c 
Adds documentation for how to rebuild all the built in analyzers and
tests for that documentation using the mechanism added in elastic#29535.

Closes elastic#29499
@nik9000 nik9000 mentioned this issue May 9, 2018
Merged
nik9000 added a commit that referenced this issue May 14, 2018
@nik9000
Docs: Document how to rebuild analyzers (#30498)
9881bfa 
Adds documentation for how to rebuild all the built in analyzers and
tests for that documentation using the mechanism added in #29535.

Closes #29499
nik9000 added a commit that referenced this issue May 14, 2018
@nik9000
Docs: Document how to rebuild analyzers (#30498)
23dc9b0 
Adds documentation for how to rebuild all the built in analyzers and
tests for that documentation using the mechanism added in #29535.

Closes #29499
@javanna javanna added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nik9000 nik9000

Labels
>docs General docs changes :Search Relevance/Analysis How text is split into tokens Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nik9000 @javanna @elasticmachine