Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smoke-test-rank-eval-with-mustache doesn't work with zip distribution #30628

Closed
nik9000 opened this issue May 15, 2018 · 2 comments
Closed

smoke-test-rank-eval-with-mustache doesn't work with zip distribution #30628

nik9000 opened this issue May 15, 2018 · 2 comments
Assignees
Labels
:Search Relevance/Ranking Scoring, rescoring, rank evaluation. Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests v6.4.0 v7.0.0-beta1

Comments

@nik9000
Copy link
Member

nik9000 commented May 15, 2018

In #30591 I'm adding support for running qa tests with the distribution configured using -Dtests.distribution. Most of the tests work except smoke-test-rank-eval-with-mustache fails because it tries to form a cluster with an ESIntegTestCase. I'm not 100% sure what the test is testing so I didn't want to change it. But I think it should be changed to work with the zip distribution.

@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests :Search Relevance/Ranking Scoring, rescoring, rank evaluation. v7.0.0 v6.4.0 labels May 15, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@nik9000
Copy link
Member Author

nik9000 commented May 15, 2018

You can reproduce the failure by removing this from qa/smoke-test-rank-eval-with-mustache/build.gradle:

/*
 * One of the integration tests doesn't work with the zip distribution
 * and will be fixed later.
 * Tracked by https://github.com/elastic/elasticsearch/issues/30628
 */
if ("zip".equals(integTestCluster.distribution)) {
    integTestRunner.enabled = false
}

And then running:

./gradlew -p qa/smoke-test-rank-eval-with-mustache/ -Dtests.distribution=zip check

@cbuescher cbuescher self-assigned this May 16, 2018
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this issue May 17, 2018
This change moves the ranking evaluation tests that use templates to the
existing yml rest tests instead of extending ESIntegTestCase.

Closes elastic#30628
cbuescher pushed a commit that referenced this issue May 24, 2018
This change moves the ranking evaluation tests that use templates to the
existing yml rest tests instead of extending ESIntegTestCase.

Closes #30628
cbuescher pushed a commit that referenced this issue May 24, 2018
This change moves the ranking evaluation tests that use templates to the
existing yml rest tests instead of extending ESIntegTestCase.

Closes #30628
@javanna javanna added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search Relevance/Ranking Scoring, rescoring, rank evaluation. Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests v6.4.0 v7.0.0-beta1
Projects
None yet
Development

No branches or pull requests

5 participants