Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: improve tests with respect to NULL values in columns #32079

Closed
astefan opened this issue Jul 16, 2018 · 1 comment · Fixed by #34573
Closed

SQL: improve tests with respect to NULL values in columns #32079

astefan opened this issue Jul 16, 2018 · 1 comment · Fixed by #34573
Assignees
@astefan
Labels
:Analytics/SQL SQL querying >enhancement

Comments

@astefan
Copy link
Contributor

astefan commented Jul 16, 2018

At the moment, the integration testing we have uses sample data that doesn't have any empty/null column values. We should improve this by adjusting the sample data to include the aforementioned values and add tests to cover related scenarios, as well.
@astefan astefan self-assigned this Jul 16, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

This was referenced Aug 14, 2018
Closed
Merged
costin added a commit to costin/elasticsearch that referenced this issue Oct 17, 2018
@costin
SQL: Introduce support for NULL values
fac5855 
Make SQL aware of missing and/or unmapped fields treating them as NULL
Make _all_ functions and operators null-safe aware, including when used
in filtering or sorting contexts
Add missing and null-safe doc value extractor
Modify dataset to have null fields spread around (in groups of 10)
Enforce missing last and unmapped_type inside sorting
Consolidate Predicate templating and declaration
Add support for Like/RLike in scripting
Introduce early schema declaration for CSV spec tests: to keep the doc
snippets in place, introduce schema:: prefix to declare the CSV schema
upfront.

Fix elastic#32079
@costin costin mentioned this issue Oct 17, 2018
Merged
costin added a commit that referenced this issue Oct 19, 2018
@costin
SQL: Introduce support for NULL values (#34573)
52104aa 
Make SQL aware of missing and/or unmapped fields treating them as NULL
Make _all_ functions and operators null-safe aware, including when used
in filtering or sorting contexts
Add missing and null-safe doc value extractor
Modify dataset to have null fields spread around (in groups of 10)
Enforce missing last and unmapped_type inside sorting
Consolidate Predicate templating and declaration
Add support for Like/RLike in scripting
Generalize NULLS LAST/FIRST
Introduce early schema declaration for CSV spec tests: to keep the doc
snippets in place (introduce schema:: prefix for declaration)
upfront.

Fix #32079
costin added a commit to costin/elasticsearch that referenced this issue Oct 19, 2018
@costin
SQL: Introduce support for NULL values (elastic#34573)
defa634 
Make SQL aware of missing and/or unmapped fields treating them as NULL
Make _all_ functions and operators null-safe aware, including when used
in filtering or sorting contexts
Add missing and null-safe doc value extractor
Modify dataset to have null fields spread around (in groups of 10)
Enforce missing last and unmapped_type inside sorting
Consolidate Predicate templating and declaration
Add support for Like/RLike in scripting
Generalize NULLS LAST/FIRST
Introduce early schema declaration for CSV spec tests: to keep the doc
snippets in place (introduce schema:: prefix for declaration)
upfront.

Fix elastic#32079

(cherry picked from commit 52104aa)
@costin costin mentioned this issue Oct 19, 2018
Merged
costin added a commit that referenced this issue Oct 19, 2018
@costin
SQL: Introduce support for NULL values (#34640)
c5b6770 
Make SQL aware of missing and/or unmapped fields treating them as NULL
Make _all_ functions and operators null-safe aware, including when used
in filtering or sorting contexts
Add missing and null-safe doc value extractor
Modify dataset to have null fields spread around (in groups of 10)
Enforce missing last and unmapped_type inside sorting
Consolidate Predicate templating and declaration
Add support for Like/RLike in scripting
Generalize NULLS LAST/FIRST
Introduce early schema declaration for CSV spec tests: to keep the doc
snippets in place (introduce schema:: prefix for declaration)
upfront.

Fix #32079

(cherry picked from commit 52104aa)
kcm pushed a commit that referenced this issue Oct 30, 2018
@costin @kcm
SQL: Introduce support for NULL values (#34573)
308bfed 
Make SQL aware of missing and/or unmapped fields treating them as NULL
Make _all_ functions and operators null-safe aware, including when used
in filtering or sorting contexts
Add missing and null-safe doc value extractor
Modify dataset to have null fields spread around (in groups of 10)
Enforce missing last and unmapped_type inside sorting
Consolidate Predicate templating and declaration
Add support for Like/RLike in scripting
Generalize NULLS LAST/FIRST
Introduce early schema declaration for CSV spec tests: to keep the doc
snippets in place (introduce schema:: prefix for declaration)
upfront.

Fix #32079
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@astefan astefan

Labels
:Analytics/SQL SQL querying >enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SQL: Introduce support for NULL values costin/elasticsearch
2 participants
@astefan @elasticmachine