Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] SSLDriverTests failures on Java 11 #32122

Closed
davidkyle opened this issue Jul 17, 2018 · 3 comments
Closed

[CI] SSLDriverTests failures on Java 11 #32122

davidkyle opened this issue Jul 17, 2018 · 3 comments
Assignees
@Tim-Brooks
Labels
jdk11 :Security/Security Security issues without another label >test-failure Triaged test failures from CI v7.0.0-beta1

Comments

@davidkyle
Copy link
Member

davidkyle commented Jul 17, 2018 •
edited
Loading

https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+matrix-java-periodic/ES_BUILD_JAVA=java11,ES_RUNTIME_JAVA=java11,nodes=virtual&&linux/181/

These test failures reproduce on Java 11 only with a range of different errors

ERROR   0.66s | SSLDriverTests.testCloseDuringHandshake <<< FAILURES!
   > Throwable #1: javax.net.ssl.SSLException: Cannot kickstart, the connection is broken or closed
   >    at __randomizedtesting.SeedInfo.seed([2728A87A7764842:5CF8D7186D9C55B5]:0)
   >    at java.base/sun.security.ssl.TransportContext.kickstart(TransportContext.java:205)
   >    at java.base/sun.security.ssl.SSLEngineImpl.writeRecord(SSLEngineImpl.java:167)
   >    at java.base/sun.security.ssl.SSLEngineImpl.wrap(SSLEngineImpl.java:138)
   >    at java.base/sun.security.ssl.SSLEngineImpl.wrap(SSLEngineImpl.java:116)
   >    at java.base/javax.net.ssl.SSLEngine.wrap(SSLEngine.java:511)

FAILURE 0.50s | SSLDriverTests.testHandshakeFailureBecauseProtocolMismatch <<< FAILURES!
   > Throwable #1: org.junit.ComparisonFailure: expected:<[Client requested protocol TLSv1 not enabled or not supported]> but was:<[Received fatal alert: protocol_version]>
   >    at __randomizedtesting.SeedInfo.seed([2728A87A7764842:9EE7D816738689EA]:0)
   >    at org.elasticsearch.xpack.security.transport.nio.SSLDriverTests.testHandshakeFailureBecauseProtocolMismatch(SSLDriverTests.java:130)

Reproduce commands:

./gradlew :x-pack:plugin:security:test \
  -Dtests.seed=2728A87A7764842 \
  -Dtests.class=org.elasticsearch.xpack.security.transport.nio.SSLDriverTests \
  -Dtests.method="testHandshakeFailureBecauseNoCiphers" \
  -Dtests.security.manager=true \
  -Dtests.locale=bs-Latn-BA \
  -Dtests.timezone=Africa/Tunis

./gradlew :x-pack:plugin:security:test \
  -Dtests.seed=2728A87A7764842 \
  -Dtests.class=org.elasticsearch.xpack.security.transport.nio.SSLDriverTests \
  -Dtests.method="testCloseDuringHandshake" \
  -Dtests.security.manager=true \
  -Dtests.locale=bs-Latn-BA \
  -Dtests.timezone=Africa/Tunis

./gradlew :x-pack:plugin:security:test \
  -Dtests.seed=2728A87A7764842 \
  -Dtests.class=org.elasticsearch.xpack.security.transport.nio.SSLDriverTests \
  -Dtests.method="testRenegotiate" \
  -Dtests.security.manager=true \
  -Dtests.locale=bs-Latn-BA \
  -Dtests.timezone=Africa/Tunis

./gradlew :x-pack:plugin:security:test \
  -Dtests.seed=2728A87A7764842 \
  -Dtests.class=org.elasticsearch.xpack.security.transport.nio.SSLDriverTests \
  -Dtests.method="testHandshakeFailureBecauseProtocolMismatch" \
  -Dtests.security.manager=true \
  -Dtests.locale=bs-Latn-BA \
  -Dtests.timezone=Africa/Tunis

./gradlew :x-pack:plugin:security:test \
  -Dtests.seed=2728A87A7764842 \
  -Dtests.class=org.elasticsearch.xpack.security.transport.nio.SimpleSecurityNioTransportTests \
  -Dtests.method="testRenegotiation" \
  -Dtests.security.manager=true \
  -Dtests.locale=zh \
  -Dtests.timezone=America/Antigua

./gradlew :x-pack:plugin:security:test \
  -Dtests.seed=2728A87A7764842 \
  -Dtests.class=org.elasticsearch.xpack.security.transport.nio.SimpleSecurityNioTransportTests \
  -Dtests.security.manager=true \
  -Dtests.locale=en-US \
  -Dtests.timezone=Etc/UTC
@davidkyle davidkyle added >test-failure Triaged test failures from CI v7.0.0 :Security/Security Security issues without another label labels Jul 17, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

@tvernum
Copy link
Contributor

tvernum commented Jul 17, 2018

Ping: @tbrooks8

@Tim-Brooks Tim-Brooks self-assigned this Jul 17, 2018
This was referenced Jul 17, 2018
Closed
Merged
@Tim-Brooks
Copy link
Contributor

Closed by #32145. #32144 is open for the one test that is muted.

Tim-Brooks added a commit that referenced this issue Jul 18, 2018
@Tim-Brooks
Adjust SSLDriver behavior for JDK11 changes (#32145)
90fcb38 
This is related to #32122. A number of things changed related to adding
TLS 1.3 support in JDK11. Some exception messages and other SSLEngine
behavior changed. This commit fixes assertions on exception messages.
Additionally it identifies two bugs related to how the SSLDriver behaves
in regards to JDK11 changes. Finally, it mutes a tests until correct
behavior can be identified. There is another open issue for that muted
test (#32144).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tim-Brooks Tim-Brooks

Labels
jdk11 :Security/Security Security issues without another label >test-failure Triaged test failures from CI v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@colings86 @Tim-Brooks @tvernum @davidkyle @jasontedor @elasticmachine