-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] DocumentSubsetReaderTests testSearch fails (seed-specific) #32457
Comments
Pinging @elastic/es-security |
@jimczi (or another Lucene expert) I think I understand why this test is failing and can guess at why it is triggered in Lucene 7.5, but I'm not sure of the best way to fix it. The problem is between lines 102 and 104 here:
Depending on the merge policy/schedule configuration (which is randomised in LuceneTestCase), it's possible that the delete would trigger a merge, which causes the "value3" document to be removed entirely, and the "value4" document become the Since Lucene 7.5 contains If that analysis is correct, what's the cleanest way to ensure that no merge happens when the document is deleted at line 103? |
Good catch @tvernum ! One workaround is to force the merge policy to choose a log merge policy (this policy does not handle the new
It seems that the test only need a single segment with a delete so it could also work if you disable the merge entirely and set a big buffer size for the index writer. Though the solution with the log merge policy should work fine. Thanks for chasing this up Tim ! |
The merge policy that was used could lead to unpredictive merges due to the randomization of `setDeletesPctAllowed`. Closes #32457
The merge policy that was used could lead to unpredictive merges due to the randomization of `setDeletesPctAllowed`. Closes #32457
There is a seed-specific failure in the DocumentSubsetReaderTests testSearch test.
This has failed on both master and 6.x.
Master:
https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+periodic/6761/console
6.x:
https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+periodic/2457/console
It's reproducible using this command:
It doesn't reproduce with other seeds.
I will mute the test on master and 6.x
The text was updated successfully, but these errors were encountered: