Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleMockNioTransportTests.testConnectException fails on MacOS #33879

Closed
tvernum opened this issue Sep 20, 2018 · 3 comments · Fixed by #33895
Closed

SimpleMockNioTransportTests.testConnectException fails on MacOS #33879

tvernum opened this issue Sep 20, 2018 · 3 comments · Fixed by #33895
Assignees
Labels
:Distributed Coordination/Network Http and internode communication implementations >test-failure Triaged test failures from CI

Comments

@tvernum
Copy link
Contributor

tvernum commented Sep 20, 2018

This seems to be triggered by #32560 (reverting 0cf0d73 solves the problem)

https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+multijob-darwin-compatibility/11/console

REPRODUCE WITH: ./gradlew :test:framework:test -Dtests.seed=9C3DC2779BDE41C3 -Dtests.class=org.elasticsearch.transport.nio.SimpleMockNioTransportTests -Dtests.method="testConnectException" -Dtests.security.manager=true -Dtests.locale=ar-LB -Dtests.timezone=America/Anchorage -Dcompiler.java=10 -Druntime.java=8
02:08:43   1> [2018-09-19T18:08:40,751][INFO ][o.e.t.t.MockTransportService] [testConnectException] publish_address {127.0.0.1:49748}, bound_addresses {[::1]:49747}, {127.0.0.1:49748}
02:08:43   1> [2018-09-19T18:08:40,773][INFO ][o.e.t.n.SimpleMockNioTransportTests] [testConnectException] after test
02:08:43 FAILURE 0.06s J3 | SimpleMockNioTransportTests.testConnectException <<< FAILURES!
02:08:43    > Throwable #1: java.lang.AssertionError: 
02:08:43    > Expected: a string containing "connect_exception"
02:08:43    >      but: was "[][127.0.0.1:9876] general node connection failure"
02:08:43    > 	at __randomizedtesting.SeedInfo.seed([9C3DC2779BDE41C3:78B03D75C4C593DD]:0)
02:08:43    > 	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
02:08:43    > 	at org.elasticsearch.transport.nio.SimpleMockNioTransportTests.testConnectException(SimpleMockNioTransportTests.java:107)
02:08:43    > 	at java.lang.Thread.run(Thread.java:748)
02:08:43   1> [2018-09-19T18:08:40,793][INFO ][o.e.t.n.SimpleMockNioTransportTests] [testErrorMessage] before test

Reproduces for me Darwin Kernel Version 16.7.0: Fri Apr 27 17:59:46 PDT 2018; root:xnu-3789.73.13~1/RELEASE_X86_64

CC: @tbrooks8

@tvernum tvernum added :Distributed Coordination/Network Http and internode communication implementations >test-failure Triaged test failures from CI labels Sep 20, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@tvernum
Copy link
Contributor Author

tvernum commented Sep 20, 2018

I muted this test on MacOS - ff934e3

tvernum added a commit that referenced this issue Sep 20, 2018
Seems to be triggered by 0cf0d73
See: #33879
@original-brownbear
Copy link
Member

@tvernum sorry about that, reproducing and fixing on OSX right away :)

original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue Sep 20, 2018
* Setting SO_LINGER for open but not connected non-blocking sockets
throws on OSX
  * Fixed by only applying setting to connected sockets which will save
the same number of FDs as doing it on open sockets anyway
* closes elastic#33879
original-brownbear added a commit that referenced this issue Sep 21, 2018
* Setting SO_LINGER for open but not connected non-blocking sockets
throws on OSX
  * Fixed by only applying setting to connected sockets which will save
the same number of FDs as doing it on open sockets anyway
* closes #33879
kcm pushed a commit that referenced this issue Oct 30, 2018
Seems to be triggered by 0cf0d73
See: #33879
kcm pushed a commit that referenced this issue Oct 30, 2018
* Setting SO_LINGER for open but not connected non-blocking sockets
throws on OSX
  * Fixed by only applying setting to connected sockets which will save
the same number of FDs as doing it on open sockets anyway
* closes #33879
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Network Http and internode communication implementations >test-failure Triaged test failures from CI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants