Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watcher Stats metrics parameters are mislabeled #34865

Closed
imotov opened this issue Oct 25, 2018 · 1 comment · Fixed by #34951
Closed

Watcher Stats metrics parameters are mislabeled #34865

imotov opened this issue Oct 25, 2018 · 1 comment · Fixed by #34951

Comments

@imotov
Copy link
Contributor

imotov commented Oct 25, 2018

While working testing HL REST client for Watcher Stats API I have noticed that the metirics parameters seem to be mislabeled:

GET /_xpack/watcher/stats/queued_watches

returns

{
...
      "current_watches": []
...
}

while

GET /_xpack/watcher/stats/pending_watches

returns

{
...
      "queued_watches": []
...
}

After discussions with @spinscale and @martijnvg, @spinscale suggested that we should

  1. queued_watches metric should return queued_watches instead of current_watches and
  2. pending_watches should be renamed into current_watches

This is a breaking change, but since nobody noticed reported this discrepancy in the last 2 years, its impact will probably be relatively minimal.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

imotov added a commit to imotov/elasticsearch that referenced this issue Oct 28, 2018
The current watcher stats metric names doesn't match the current
documentation. This commit fixes the behavior of `queued_watches`
metric, deprecates `pending_watches` metric and adds `current_watches`
to match the documented behavior. It also fixes the documentation, which
introduced `executing_watches` metric that was never added.

Fixes elastic#34865
imotov added a commit that referenced this issue Nov 1, 2018
* Watcher: fix metric stats names

The current watcher stats metric names doesn't match the current
documentation. This commit fixes the behavior of `queued_watches`
metric, deprecates `pending_watches` metric and adds `current_watches`
to match the documented behavior. It also fixes the documentation, which
introduced `executing_watches` metric that was never added.

Fixes #34865
imotov added a commit that referenced this issue Nov 1, 2018
The current watcher stats metric names doesn't match the current
documentation. This commit fixes the behavior of `queued_watches`
metric, deprecates `pending_watches` metric and adds `current_watches`
to match the documented behavior. It also fixes the documentation, which
introduced `executing_watches` metric that was never added.

Fixes #34865
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants