Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename "minimum_age" to "min_age" in ILM Phase Definitions #34927

Closed
talevy opened this issue Oct 26, 2018 · 4 comments
Closed

rename "minimum_age" to "min_age" in ILM Phase Definitions #34927

talevy opened this issue Oct 26, 2018 · 4 comments
Labels
blocker :Data Management/ILM+SLM Index and Snapshot lifecycle management

Comments

@talevy
Copy link
Contributor

talevy commented Oct 26, 2018

problem: There is inconsistency between the usage of min and max shorthands for
minimum and maximum. ILM's minimum_age for phase policy times adds to this inconsistency

solution: refactor minimum_age to be min_age

@talevy talevy added blocker :Data Management/ILM+SLM Index and Snapshot lifecycle management labels Oct 26, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@nishantraut
Copy link

Hi @talevy and Team,
I am new to this project, would like to start contribution, can you guide me. Thanks

@talevy talevy self-assigned this Oct 29, 2018
@talevy
Copy link
Contributor Author

talevy commented Oct 29, 2018

hi @nishantraut, Although this issue would be a good first issue, I am going to work on this because we would like to get it in ASAP.

If you are interested in picking up other good first issues, we have a "good first issue" label where you can find other issues in ES that would be good starting points

issue list: https://github.com/elastic/elasticsearch/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22.

thank you for your interest in contributing! any help is very much appreciated!

talevy added a commit to talevy/elasticsearch that referenced this issue Oct 29, 2018
@talevy
Copy link
Contributor Author

talevy commented Oct 30, 2018

closed in #35058

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker :Data Management/ILM+SLM Index and Snapshot lifecycle management
Projects
None yet
Development

No branches or pull requests

3 participants