Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Frame Analytics memory estimation ignores Query #49454

Closed
benwtrent opened this issue Nov 21, 2019 · 2 comments · Fixed by #49517
Closed

Data Frame Analytics memory estimation ignores Query #49454

benwtrent opened this issue Nov 21, 2019 · 2 comments · Fixed by #49517
Assignees
@dimitris-athanasiou
Labels
>bug :ml Machine learning

Comments

@benwtrent
Copy link
Member

The Memory estimation process uses the extractor against the source index before the data frame analytics process runs. But, in doing this, it ignores the the data frame analytics source query.

Extractor simply does a match_all: https://github.com/elastic/elasticsearch/blob/1dd816f030e256f497c1726695d1209a481b9d8e/x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/dataframe/extractor/DataFrameDataExtractorFactory.java#L42..L58

And the estimation process uses the extractor to determine row and column counts: https://github.com/elastic/elasticsearch/blob/12528b351a99941ffc1d44dd2c0265768ef79635/x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/dataframe/process/MemoryUsageEstimationProcessManager.java#L59..L60

The memory estimator needs to account for a defined query when estimating against the source index.
@benwtrent benwtrent added >bug :ml Machine learning labels Nov 21, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@dimitris-athanasiou dimitris-athanasiou self-assigned this Nov 21, 2019
@LucaWintergerst
Copy link
Contributor

adding the exception as well so other people running into this can find this issue easier:
Cannot start because the configured model memory limit [50mb] is lower than the expected memory usage [843.6mb]

dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this issue Nov 24, 2019
@dimitris-athanasiou
[ML] Apply source query on data frame analytics memory estimation
c3ca17e 
Closes elastic#49454
@dimitris-athanasiou dimitris-athanasiou mentioned this issue Nov 24, 2019
Merged
dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this issue Nov 25, 2019
@dimitris-athanasiou
[ML] Apply source query on data frame analytics memory estimation
05b6530 
Closes elastic#49454
@dimitris-athanasiou dimitris-athanasiou mentioned this issue Nov 25, 2019
Merged
dimitris-athanasiou added a commit that referenced this issue Nov 25, 2019
@dimitris-athanasiou
[ML] Apply source query on data frame analytics memory estimation (#4…
1865d87 
…9517)

Closes #49454
dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this issue Nov 25, 2019
@dimitris-athanasiou
[7.x][ML] Apply source query on data frame analytics memory estimation (
60c2746 
elastic#49517)

Closes elastic#49454

Backport of elastic#49517
@dimitris-athanasiou dimitris-athanasiou mentioned this issue Nov 25, 2019
Merged
dimitris-athanasiou added a commit that referenced this issue Nov 25, 2019
@dimitris-athanasiou
[7.x][ML] Apply source query on data frame analytics memory estimation (
c149c64 
#49517) (#49532)

Closes #49454

Backport of #49517
dimitris-athanasiou added a commit that referenced this issue Dec 2, 2019
@dimitris-athanasiou
[ML] Apply source query on data frame analytics memory estimation (#4…
1a6b048 
…9527)

Closes #49454
@jpountz jpountz changed the title [ML] Data Frame Analytics memory estimation ignores Query Data Frame Analytics memory estimation ignores Query Dec 18, 2019
This was referenced Feb 3, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimitris-athanasiou dimitris-athanasiou

Labels
>bug :ml Machine learning
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ML] Apply source query on data frame analytics memory estimation dimitris-athanasiou/elasticsearch
4 participants
@benwtrent @dimitris-athanasiou @LucaWintergerst @elasticmachine