[CI] Failure in SumIT.testSingleValuedFieldWithFormatter

[original-brownbear]

In https://gradle-enterprise.elastic.co/s/zyfrpx2dhy4tq/console-log?anchor=4774 7.x

REPRODUCE WITH: ./gradlew ':server:integTest' --tests "org.elasticsearch.search.aggregations.metrics.SumIT.testSingleValuedFieldWithFormatter" -Dtests.seed=51FCA3F5A8A9E7FA -Dtests.security.manager=true -Dtests.locale=is-IS -Dtests.timezone=IST -Dcompiler.java=12 -Druntime.java=8
 

Fails with some NPE:

org.elasticsearch.search.aggregations.metrics.SumIT > testSingleValuedFieldWithFormatter FAILED |  
-- | --
  | Failed to execute phase [dfs_query], |  
  |   |  
  | Caused by: |  
  | java.lang.NullPointerException

[elasticmachine]

Pinging @elastic/es-search (:Search/Search)

[iverase]

I found more errors like this one, it does not reproduce. The stack trace looks like:

Caused by: java.lang.NullPointerException
	at org.elasticsearch.action.search.SearchProgressListener.searchShards(SearchProgressListener.java:166)
	at org.elasticsearch.action.search.SearchPhaseController$QueryPhaseResultConsumer.consumeInternal(SearchPhaseController.java:639)
	at org.elasticsearch.action.search.SearchPhaseController$QueryPhaseResultConsumer.consumeResult(SearchPhaseController.java:617)
	at org.elasticsearch.action.search.CountedCollector.onResult(CountedCollector.java:62)
	at org.elasticsearch.action.search.DfsQueryPhase$1.innerOnResponse(DfsQueryPhase.java:89)
	... 24 more

This seems be related with PR #49471, @jimczi any ideas?

[iverase]

I think the error come from this call:

elasticsearch/server/src/main/java/org/elasticsearch/action/search/SearchPhaseController.java

Line 639 in cab99c0

progressListener.notifyPartialReduce(progressListener.searchShards(results.asList()),

This is a bit out my depth but the method is synchronised but the result that is given to the method seems to be shared across threads so I wonder if this is a concurrency issue.