Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RecoverySourceHandlerTests.testCancelRecoveryDuringPhase1 failing #50424

Closed
ywelsch opened this issue Dec 20, 2019 · 2 comments · Fixed by #50449
Closed

RecoverySourceHandlerTests.testCancelRecoveryDuringPhase1 failing #50424

ywelsch opened this issue Dec 20, 2019 · 2 comments · Fixed by #50449
Assignees
@dnhatn
Labels
:Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. >test-failure Triaged test failures from CI

Comments

@ywelsch
Copy link
Contributor

ywelsch commented Dec 20, 2019

Test failure is reproducible. Possibly related to #50351.

https://gradle-enterprise.elastic.co/s/7qzhu37ptbtl4

REPRODUCE WITH: ./gradlew ':server:test' --tests "org.elasticsearch.indices.recovery.RecoverySourceHandlerTests" \
  -Dtests.seed=FB712647FCD390D3 \
  -Dtests.security.manager=true \
  -Dbuild.snapshot=false \
  -Dtests.jvm.argline="-Dbuild.snapshot=false" \
  -Dtests.locale=en-US \
  -Dtests.timezone=UTC \
  -Dcompiler.java=13
@ywelsch ywelsch added >test-failure Triaged test failures from CI :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. labels Dec 20, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Recovery)

ywelsch added a commit that referenced this issue Dec 20, 2019
@ywelsch
Mute RecoverySourceHandlerTests.testCancelRecoveryDuringPhase1
fa343f9 
Relates #50424
@ywelsch
Copy link
Contributor Author

ywelsch commented Dec 20, 2019

I've muted the test in fa343f9

@dnhatn dnhatn mentioned this issue Dec 20, 2019
Merged
dnhatn pushed a commit that referenced this issue Dec 24, 2019
@ywelsch @dnhatn
Mute RecoverySourceHandlerTests.testCancelRecoveryDuringPhase1
f57569b 
Relates #50424
dnhatn added a commit that referenced this issue Dec 26, 2019
@dnhatn
Fix testCancelRecoveryDuringPhase1 (#50449)
50bd584 
testCancelRecoveryDuringPhase1 uses a mock of IndexShard, which can't
create retention leases. We need to stub method createRetentionLease.

Relates #50351 
Closes #50424
dnhatn added a commit that referenced this issue Dec 26, 2019
@dnhatn
Fix testCancelRecoveryDuringPhase1 (#50449)
7713221 
testCancelRecoveryDuringPhase1 uses a mock of IndexShard, which can't
create retention leases. We need to stub method createRetentionLease.

Relates #50351 
Closes #50424
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this issue Jan 23, 2020
@ywelsch @SivagurunathanV
Mute RecoverySourceHandlerTests.testCancelRecoveryDuringPhase1
d7be9ae 
Relates elastic#50424
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this issue Jan 23, 2020
@dnhatn @SivagurunathanV
Fix testCancelRecoveryDuringPhase1 (elastic#50449)
6b5ee4d 
testCancelRecoveryDuringPhase1 uses a mock of IndexShard, which can't
create retention leases. We need to stub method createRetentionLease.

Relates elastic#50351 
Closes elastic#50424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnhatn dnhatn

Labels
:Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix testCancelRecoveryDuringPhase1 dnhatn/elasticsearch
3 participants
@ywelsch @dnhatn @elasticmachine