Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GoogleCloudStorageBlobContainerRetriesTests.testWriteLargeBlob fails #50754

Closed
dnhatn opened this issue Jan 8, 2020 · 1 comment · Fixed by #51593
Closed

GoogleCloudStorageBlobContainerRetriesTests.testWriteLargeBlob fails #50754

dnhatn opened this issue Jan 8, 2020 · 1 comment · Fixed by #51593
Assignees
@original-brownbear
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test-failure Triaged test failures from CI

Comments

@dnhatn
Copy link
Member

dnhatn commented Jan 8, 2020

GoogleCloudStorageBlobContainerRetriesTests.testWriteLargeBlob has failed several times last week (see build stats). Some instances:
@dnhatn dnhatn added :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test-failure Triaged test failures from CI labels Jan 8, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore)

@original-brownbear original-brownbear self-assigned this Jan 8, 2020
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue Jan 8, 2020
@original-brownbear
Enforce Logging of Errors in GCS Rest RetriesTests
c3f1445 
It's impossible to tell why elastic#50754 fails without this change.
We're failing to close the `exchange` somewhere and there is no
write timeout in the GCS SDK (something to look into separately)
only a read timeout on the socket so if we're failing on an assertion without
reading the full request body (at least into the read-buffer) we're locking up
waiting forever on `write0`.

This change ensure the `exchange` is closed in the tests where we could lock up
on a write and logs the failure so we can find out what broke elastic#50754.
@original-brownbear original-brownbear mentioned this issue Jan 8, 2020
Merged
original-brownbear added a commit that referenced this issue Jan 9, 2020
@original-brownbear
Enforce Logging of Errors in GCS Rest RetriesTests (#50761)
95fcee2 
It's impossible to tell why #50754 fails without this change.
We're failing to close the `exchange` somewhere and there is no
write timeout in the GCS SDK (something to look into separately)
only a read timeout on the socket so if we're failing on an assertion without
reading the full request body (at least into the read-buffer) we're locking up
waiting forever on `write0`.

This change ensure the `exchange` is closed in the tests where we could lock up
on a write and logs the failure so we can find out what broke #50754.
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue Jan 9, 2020
@original-brownbear
Enforce Logging of Errors in GCS Rest RetriesTests (elastic#50761)
f967c85 
It's impossible to tell why elastic#50754 fails without this change.
We're failing to close the `exchange` somewhere and there is no
write timeout in the GCS SDK (something to look into separately)
only a read timeout on the socket so if we're failing on an assertion without
reading the full request body (at least into the read-buffer) we're locking up
waiting forever on `write0`.

This change ensure the `exchange` is closed in the tests where we could lock up
on a write and logs the failure so we can find out what broke elastic#50754.
@original-brownbear original-brownbear mentioned this issue Jan 9, 2020
Merged
original-brownbear added a commit that referenced this issue Jan 9, 2020
@original-brownbear
Enforce Logging of Errors in GCS Rest RetriesTests (#50761) (#50783)
4a7e09f 
It's impossible to tell why #50754 fails without this change.
We're failing to close the `exchange` somewhere and there is no
write timeout in the GCS SDK (something to look into separately)
only a read timeout on the socket so if we're failing on an assertion without
reading the full request body (at least into the read-buffer) we're locking up
waiting forever on `write0`.

This change ensure the `exchange` is closed in the tests where we could lock up
on a write and logs the failure so we can find out what broke #50754.
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this issue Jan 23, 2020
@original-brownbear @SivagurunathanV
Enforce Logging of Errors in GCS Rest RetriesTests (elastic#50761)
1ecb19e 
It's impossible to tell why elastic#50754 fails without this change.
We're failing to close the `exchange` somewhere and there is no
write timeout in the GCS SDK (something to look into separately)
only a read timeout on the socket so if we're failing on an assertion without
reading the full request body (at least into the read-buffer) we're locking up
waiting forever on `write0`.

This change ensure the `exchange` is closed in the tests where we could lock up
on a write and logs the failure so we can find out what broke elastic#50754.
@original-brownbear original-brownbear mentioned this issue Jan 29, 2020
Merged
original-brownbear added a commit that referenced this issue Jan 29, 2020
@original-brownbear
Optimize GCS Mock (#51593)
0952c21 
This test was still very GC heavy in Java 8 runs in particular
which seems to slow down request processing to the point of timeouts
in some runs.
This PR completely removes the large number of O(MB) `byte[]` allocations
that were happening in the mock http handler which cuts the allocation rate
by about a factor of 5 in my local testing for the GC heavy `testSnapshotWithLargeSegmentFiles`
run.

Closes #51446
Closes #50754
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue Jan 29, 2020
@original-brownbear
Optimize GCS Mock (elastic#51593)
a11e51d 
This test was still very GC heavy in Java 8 runs in particular
which seems to slow down request processing to the point of timeouts
in some runs.
This PR completely removes the large number of O(MB) `byte[]` allocations
that were happening in the mock http handler which cuts the allocation rate
by about a factor of 5 in my local testing for the GC heavy `testSnapshotWithLargeSegmentFiles`
run.

Closes elastic#51446
Closes elastic#50754
@original-brownbear original-brownbear mentioned this issue Jan 29, 2020
Merged
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue Jan 29, 2020
@original-brownbear
Optimize GCS Mock (elastic#51593)
114deff 
This test was still very GC heavy in Java 8 runs in particular
which seems to slow down request processing to the point of timeouts
in some runs.
This PR completely removes the large number of O(MB) `byte[]` allocations
that were happening in the mock http handler which cuts the allocation rate
by about a factor of 5 in my local testing for the GC heavy `testSnapshotWithLargeSegmentFiles`
run.

Closes elastic#51446
Closes elastic#50754
@original-brownbear original-brownbear mentioned this issue Jan 29, 2020
Merged
original-brownbear added a commit that referenced this issue Jan 29, 2020
@original-brownbear
Optimize GCS Mock (#51593) (#51594)
7914c1a 
This test was still very GC heavy in Java 8 runs in particular
which seems to slow down request processing to the point of timeouts
in some runs.
This PR completely removes the large number of O(MB) `byte[]` allocations
that were happening in the mock http handler which cuts the allocation rate
by about a factor of 5 in my local testing for the GC heavy `testSnapshotWithLargeSegmentFiles`
run.

Closes #51446
Closes #50754
original-brownbear added a commit that referenced this issue Jan 29, 2020
@original-brownbear
Optimize GCS Mock (#51593) (#51595)
09f8d4b 
This test was still very GC heavy in Java 8 runs in particular
which seems to slow down request processing to the point of timeouts
in some runs.
This PR completely removes the large number of O(MB) `byte[]` allocations
that were happening in the mock http handler which cuts the allocation rate
by about a factor of 5 in my local testing for the GC heavy `testSnapshotWithLargeSegmentFiles`
run.

Closes #51446
Closes #50754
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@original-brownbear original-brownbear

Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimize GCS Mock original-brownbear/elasticsearch
3 participants
@original-brownbear @dnhatn @elasticmachine