Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] TimeSeriesLifecycleActionsIT.testHistoryIsWrittenWithFailure failing to assert step #52853

Closed
mark-vieira opened this issue Feb 26, 2020 · 3 comments · Fixed by #53306
Closed

[CI] TimeSeriesLifecycleActionsIT.testHistoryIsWrittenWithFailure failing to assert step #52853

mark-vieira opened this issue Feb 26, 2020 · 3 comments · Fixed by #53306
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >test-failure Triaged test failures from CI

Comments

@mark-vieira
Copy link
Contributor

There's an existing issue for this same test (#50353) but that is failing on a different assertion so it's not clear if this is the same problem. If these both have the same root cause feel free to close this as a duplicate.

org.elasticsearch.xpack.ilm.TimeSeriesLifecycleActionsIT > testHistoryIsWrittenWithFailure FAILED
    java.lang.AssertionError: 
    Expected: "ERROR"
         but: was "check-rollover-ready"
        at __randomizedtesting.SeedInfo.seed([25743638EB0838F4:A51AEC54A0F27B30]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.junit.Assert.assertThat(Assert.java:956)
        at org.junit.Assert.assertThat(Assert.java:923)
        at org.elasticsearch.xpack.ilm.TimeSeriesLifecycleActionsIT.lambda$testHistoryIsWrittenWithFailure$104(TimeSeriesLifecycleActionsIT.java:1433)
        at org.elasticsearch.test.ESTestCase.assertBusy(ESTestCase.java:881)
        at org.elasticsearch.test.ESTestCase.assertBusy(ESTestCase.java:854)
        at org.elasticsearch.xpack.ilm.TimeSeriesLifecycleActionsIT.testHistoryIsWrittenWithFailure(TimeSeriesLifecycleActionsIT.java:1433)
REPRODUCE WITH: ./gradlew ':x-pack:plugin:ilm:qa:multi-node:integTestRunner' --tests "org.elasticsearch.xpack.ilm.TimeSeriesLifecycleActionsIT.testHistoryIsWrittenWithFailure" -Dtests.seed=25743638EB0838F4 -Dtests.security.manager=true -Dtests.locale=es-DO -Dtests.timezone=Asia/Aden -Dcompiler.java=13

https://gradle-enterprise.elastic.co/s/xmnuuygmxv4ky/tests/ao2nxxbijves6-iqisezgxfz7vq
https://gradle-enterprise.elastic.co/s/6lb3nya5vvutu/tests/ao2nxxbijves6-iqisezgxfz7vq
https://gradle-enterprise.elastic.co/s/rhh26e3fddsvq/tests/ao2nxxbijves6-iqisezgxfz7vq
https://gradle-enterprise.elastic.co/s/n5fq6qztklpb4/tests/ao2nxxbijves6-iqisezgxfz7vq
@mark-vieira mark-vieira added >test-failure Triaged test failures from CI :Data Management/ILM+SLM Index and Snapshot lifecycle management labels Feb 26, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/ILM+SLM)

@mark-vieira mark-vieira mentioned this issue Feb 26, 2020
Closed
probakowski added a commit to probakowski/elasticsearch that referenced this issue Mar 2, 2020
@probakowski
Avoid race condition in ILMHistorySotre
ccc6d16 
This change modifies ILMHistoryStore to always apply correct settings and mappings,
even if template is deleted and not yet recreated. This ensures that ILM history index
is correctly managed by ILM and also fixes flaky history tests that were prone to
triggenring this race.

This commit also refactors and simplifies ILM history tests.

Closes elastic#50353 and elastic#52853
@probakowski probakowski mentioned this issue Mar 2, 2020
Merged
probakowski added a commit that referenced this issue Mar 4, 2020
@probakowski @elasticmachine
Avoid race condition in ILMHistorySotre (#53039)
2a9c1f8 
* Avoid race condition in ILMHistorySotre

This change modifies ILMHistoryStore to always apply correct settings and mappings,
even if template is deleted and not yet recreated. This ensures that ILM history index
is correctly managed by ILM and also fixes flaky history tests that were prone to
triggenring this race.

This commit also refactors and simplifies ILM history tests.

Closes #50353 and #52853

* Review comment

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
probakowski added a commit to probakowski/elasticsearch that referenced this issue Mar 4, 2020
@probakowski @elasticmachine
Avoid race condition in ILMHistorySotre (elastic#53039)
9251392 
* Avoid race condition in ILMHistorySotre

This change modifies ILMHistoryStore to always apply correct settings and mappings,
even if template is deleted and not yet recreated. This ensures that ILM history index
is correctly managed by ILM and also fixes flaky history tests that were prone to
triggenring this race.

This commit also refactors and simplifies ILM history tests.

Closes elastic#50353 and elastic#52853

* Review comment

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@jbaiera
Copy link
Member

jbaiera commented Mar 5, 2020

We've had a couple more failures of this specific test in the last couple of days:

https://gradle-enterprise.elastic.co/s/qhraswyh3qk6g
https://gradle-enterprise.elastic.co/s/cfyqrwx5isfjw

@jbaiera jbaiera reopened this Mar 5, 2020
@mark-vieira
Copy link
Contributor Author

@jbaiera Looks like the fix in #53039 didn't completely eliminate this. We should remute.

@probakowski probakowski mentioned this issue Mar 9, 2020
Merged
probakowski added a commit that referenced this issue Mar 9, 2020
@probakowski @elasticmachine
[7.x] Avoid race condition in ILMHistorySotre (#53039) (#53094)
f075d70 
* Avoid race condition in ILMHistorySotre (#53039)

* Avoid race condition in ILMHistorySotre

This change modifies ILMHistoryStore to always apply correct settings and mappings,
even if template is deleted and not yet recreated. This ensures that ILM history index
is correctly managed by ILM and also fixes flaky history tests that were prone to
triggenring this race.

This commit also refactors and simplifies ILM history tests.

Closes #50353 and #52853

* Review comment

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* fixed tests

* backport #53306

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@codebrain codebrain mentioned this issue Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
4 participants
@jbaiera @probakowski @mark-vieira @elasticmachine