Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QL: remove constant_keyword from code base #58471

Closed
astefan opened this issue Jun 24, 2020 · 4 comments
Closed

QL: remove constant_keyword from code base #58471

astefan opened this issue Jun 24, 2020 · 4 comments
Assignees
@astefan
Labels
:Analytics/EQL EQL querying :Analytics/SQL SQL querying >non-issue >refactoring Team:QL (Deprecated) Meta label for query languages team

Comments

@astefan
Copy link
Contributor

astefan commented Jun 24, 2020

Following #58315 merging, there is no need for constant_keyword field type in QL projects anymore.
@astefan astefan added >enhancement >non-issue >refactoring :Analytics/SQL SQL querying :Analytics/EQL EQL querying needs:triage Requires assignment of a team area label labels Jun 24, 2020
@astefan astefan self-assigned this Jun 24, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (:Query Languages/SQL)

@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label Jun 24, 2020
@astefan astefan removed >enhancement needs:triage Requires assignment of a team area label labels Jun 24, 2020
@astefan astefan mentioned this issue Jul 31, 2020
Merged
@keremh
Copy link

keremh commented Oct 8, 2020

Hello @astefan, i want to work on this issue 👍

@astefan
Copy link
Contributor Author

astefan commented Oct 19, 2020

Hi @keremh , thank you for your interest in helping out with this gh issue. There is a PR already opened for this which is waiting on bwc tests to be complete and further merged in master afterwards.

@bpintea
Copy link
Contributor

bpintea commented Nov 6, 2020

Fixed by #60524.

@bpintea bpintea closed this as completed Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@astefan astefan

Labels
:Analytics/EQL EQL querying :Analytics/SQL SQL querying >non-issue >refactoring Team:QL (Deprecated) Meta label for query languages team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@astefan @bpintea @keremh @elasticmachine