-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make keyword
a family of field types
#58315
Conversation
Pinging @elastic/es-search (:Search/Mapping) |
I guess we have no choice but to replace all instance of |
I got a little lost chasing expected vs actuals discrepancies when it looks like a lot of the expectations might come from |
@markharwood you're on the right path. The *.csv-spec files are the ones that indicate what we expect. For example: Hope this helps. |
Tagging @astefan for awareness since once this PR lands, we should remove the |
2bbc75d
to
0609e98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we should also update the documentation in _field_caps
to explain the keyword
family ?
…or field capabilities. Relates to elastic#53175
…58315) Introduces a new method on `MappedFieldType` to return a family type name which defaults to the field type. Changes `wildcard` and `constant_keyword` field types to return `keyword` for field capabilities. Relates to elastic#53175
@markharwood perhaps we should make a note in the migration/ breaking changes docs for 7.x explaining that |
This change introduces a
familyTypeName
method to MappedFieldType for use in the field capabilities API.The
constant_keyword
andwildcard
fields override this to returnkeyword
to describe the family to which they belong.Relates to #53175