Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synthetic Source #86603

Closed
44 of 50 tasks
nik9000 opened this issue May 10, 2022 · 11 comments
Closed
44 of 50 tasks

Synthetic Source #86603

nik9000 opened this issue May 10, 2022 · 11 comments

Comments

@nik9000
Copy link
Member

nik9000 commented May 10, 2022

This shrinks the index by implementing a "synthetic" _source field. Instead of saving the field to disk we reconstruct it on the fly using our column store, doc values.

Before removing the feature flag

Later

Much later

  • Synthesize instead of using _recovery_source - we find that it'd improve write performance by ~11%. We'd have to synthesize on load instead. That's pretty slow. We'd love the 11% but we have to be careful here.

image

@nik9000 nik9000 added >enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types Meta :StorageEngine/TSDB You know, for Metrics labels May 10, 2022
@elasticmachine elasticmachine added Team:Search Meta label for search team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels May 10, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@jsoriano
Copy link
Member

@nik9000 does synthetic source leverage _source_include/_source_exclude for the fields it has to synthesize?

@nik9000
Copy link
Member Author

nik9000 commented Jul 26, 2022

@nik9000 does synthetic source leverage _source_include/_source_exclude for the fields it has to synthesize?

It does not. There is no support at the moment for any kind of partial synthesis.

@rocco8620
Copy link

Awesome feature, can't wait to have this in GA!!

@Kiriakos1998
Copy link
Contributor

Hello @nik9000 , can I pick some of the unchecked subtasks?

@nik9000
Copy link
Member Author

nik9000 commented May 31, 2023

Hello @nik9000 , can I pick some of the unchecked subtasks?

I think all of the unchecked tasks are quick difficult to be honest. ignore_malformed are maybe easier, but I wouldn't suggest picking it up.

Also you'd need a committer buddy and I've had to move on to other tasks sadly. That might be quite difficult to find too.

@iby-dev
Copy link

iby-dev commented Mar 22, 2024

@nik9000 does synthetic source leverage _source_include/_source_exclude for the fields it has to synthesize?

It does not. There is no support at the moment for any kind of partial synthesis.

Hi @nik9000 - just for my own clarity. You can either use mode: synthetic on its own or use the _source_include/_source_exclude ? But the two cannot be combined ? Is this correct ?

@nik9000
Copy link
Member Author

nik9000 commented Mar 22, 2024

Hi @nik9000 - just for my own clarity. You can either use mode: synthetic on its own or use the _source_include/_source_exclude ? But the two cannot be combined ? Is this correct ?

Right. I honestly didn't know how to combine them so I just declared combining them to be incompatible.

Keep in mind synthetic source is only GA for time series indices and data streams. I've had to move on to other things but expect folks will get back to working on getting synthetic source good in more contexts at some point soon.

@martijnvg martijnvg added :StorageEngine/Mapping The storage related side of mappings and removed :Search Foundations/Mapping Index mappings, including merging and defining field types :StorageEngine/TSDB You know, for Metrics labels May 31, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@elasticsearchmachine elasticsearchmachine removed the Team:Search Meta label for search team label May 31, 2024
@elasticsearchmachine elasticsearchmachine removed the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label May 31, 2024
@martijnvg
Copy link
Member

I'm closing this issue, because most of the mentioned items have been completed. Most of the uncompleted items have dedicated issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants