Support complex datemath expressions in index and index alias names #100646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodk85
added
>bug
:Search/Search
|
Hi @volodk85, I've created a changelog YAML for you. |
|
Jenkins run elasticsearch-ci/bwc |
|
Pinging @elastic/es-search (Team:Search) |
|
@quux00 could you have a look at this please? |
quux00
reviewed
Oct 12, 2023
| @@ -160,6 +160,11 @@ private static SearchRequest skipRemoteIndexNames(SearchRequest source) { | |||
| } | |||
|
|
|||
| private static boolean isRemoteExpression(String expression) { | |||
| return expression.contains(":"); | |||
| // remote index name contains ':' symbol inside their names (remote cluster name separator), e.g. cluster0:index-name | |||
There was a problem hiding this comment.
This comment is worded slightly incorrectly. I think the better way to say it would be:
An index expression that references a remote cluster uses ":" to separate the cluster-alias from the index portion of the expression, e.g., cluster0:index-name ...
quux00
approved these changes
Oct 12, 2023
|
Jenkins run elasticsearch-ci/part-3 |
|
@elasticmachine update branch |
This was referenced Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this call trips over if Search/Count/Reindex API is queried with complex date-math index name which contains semicolon
:inside(human readable index name is:
<datemath-{2001-01-01-13||+1h/h{yyyy-MM-dd-HH|-07:00}}>and it evaluates to
datemath-2001-01-01-14){"error":{"root_cause":[{"type":"no_such_remote_cluster_exception","reason":"no such remote cluster: [<datemath-{2001-01-01-13||+1h/h{yyyy-MM-dd-HH|-07]","stack_trace":"org.elasticsearch.transport.NoSuchRemoteClusterException: no such remote cluster: [<datemath-{2001-01-01-13||+1h/h{yyyy-MM-dd-HH|-07]\n\tat org.elasticsearch.server@8.12.0-SNAPSHOT/org.elasticsearch.cluster.metadata.ClusterNameExpressionResolver.resolveClusterNames(ClusterNameExpressionResolver.java:41)\n\tat org.elasticsearch.server@8.12.0-SNAPSHOT/org.elasticsearch.transport.RemoteClusterAware.groupClusterIndices(RemoteClusterAware.java:85)\n\tat org.elasticsearch.server@8.12.0-SNAPSHOT/org.elasticsearch.transport.RemoteClusterService.groupIndices(RemoteClusterService.java:181)
More info is here #96968 (comment)