Reapply "Making yaml tests version selector parser compatible with versions returned by Build" #100953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parsing-yaml-tests
…parsing-yaml-tests
…patible-version-parsing-yaml-tests
elasticsearchmachine
added
the
needs:triage
ldematte
added
:Core/Infra/REST API
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
williamrandolph
approved these changes
Oct 23, 2023
test/yaml-rest-runner/src/main/java/org/elasticsearch/test/rest/yaml/section/DoSection.java
Outdated
Show resolved
Hide resolved
| Version version = Version.fromString(node.getVersion()); | ||
| boolean skip = skipVersionRanges.stream().anyMatch(v -> v.contains(version)); | ||
| if (false == skip) { | ||
| if (nodeMatcher.test(versionString) == false) { |
There was a problem hiding this comment.
If we do replace("-SNAPSHOT", "") here, the possible matchers both get simplified.
There was a problem hiding this comment.
Yes, it could become a simple string equals. Same as above, I will change it - it should work, and if not CI test failures will tell us.
|
@elasticmachine rerun elasticsearch-ci/check-serverless-submodule |
…version-parsing-yaml-tests
|
Thank you William! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reapply #100794
This will need to be merged (again) after #100947 and then be followed by #100746 OR follow quickly #100746 to avoid disruption in serverless.