Remove ThreadGroup#allowThreadSuspension from forbidden APIs #101651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
java.lang.ThreadGroup#allowThreadSuspension(boolean) was removed in JDK 21. See https://www.oracle.com/java/technologies/javase/21all-relnotes.html#JDK-8297295
williamrandolph
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
I assume we don't have any usages of this then otherwise we'd see runtime errors when running on a Java 21 JRE? |
|
@elasticsearchmachine please run elasticsearch-ci/part-1 |
|
@mark-vieira Right. If there were usages, we'd have hit runtime or compilation failures when we moved to JDK 21. And a |
This was referenced Nov 1, 2023
williamrandolph
added a commit
to williamrandolph/elasticsearch
that referenced
this pull request
Nov 1, 2023
…#101651) java.lang.ThreadGroup#allowThreadSuspension(boolean) was removed in JDK 21. See https://www.oracle.com/java/technologies/javase/21all-relnotes.html#JDK-8297295
williamrandolph
added a commit
to williamrandolph/elasticsearch
that referenced
this pull request
Nov 1, 2023
…#101651) java.lang.ThreadGroup#allowThreadSuspension(boolean) was removed in JDK 21. See https://www.oracle.com/java/technologies/javase/21all-relnotes.html#JDK-8297295
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 1, 2023
#101659) java.lang.ThreadGroup#allowThreadSuspension(boolean) was removed in JDK 21. See https://www.oracle.com/java/technologies/javase/21all-relnotes.html#JDK-8297295
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 1, 2023
#101658) java.lang.ThreadGroup#allowThreadSuspension(boolean) was removed in JDK 21. See https://www.oracle.com/java/technologies/javase/21all-relnotes.html#JDK-8297295
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java.lang.ThreadGroup#allowThreadSuspension(boolean) was removed in JDK 21. See https://www.oracle.com/java/technologies/javase/21all-relnotes.html#JDK-8297295