ESQL: Fix single value query #102317
Merged
ESQL: Fix single value query #102317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the lucene query that we use to push "is this a single valued field?" into lucene. In particular, it was erroniously turning itself into a noop any time it saw a field that could have either 0 or 1 value per document. It's right and good for the query to noop itself only when a field can only have 1 value per document. This adds logic to check for that. Closes elastic#102298
|
Hi @nik9000, I've created a changelog YAML for you. |
elasticsearchmachine
added
the
Team:QL (Deprecated)
|
Pinging @elastic/es-ql (Team:QL) |
|
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
|
This could manifest as some document being erroniously found in a field when that has 0 or 1 value per document. Given that lucene queries don't typically match when there aren't any values you are unlikely to see this unless you negate the query - so something like |
dnhatn
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the lucene query that we use to push "is this a single valued field?" into lucene. In particular, it was erroniously turning itself into a noop any time it saw a field that could have either 0 or 1 value per document. It's right and good for the query to noop itself only when a field can only have 1 value per document. This adds logic to check for that.
Closes #102298