IndexShardRoutingTable should always be nonempty
#105720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's only one remaining test that creates an empty `IndexShardRoutingTable`. This commit fixes that, and then adds an assertion to enforce that all `IndexShardRoutingTable` instances include at least a primary shard.
DaveCTurner
added
>non-issue
:Distributed Coordination/Allocation
|
Pinging @elastic/es-distributed (Team:Distributed) |
elasticsearchmachine
added
the
Team:Distributed
ywangd
approved these changes
Feb 22, 2024
| @@ -114,7 +115,8 @@ public class IndexShardRoutingTable { | |||
| allShardsStarted = false; | |||
| } | |||
| } | |||
| assert primary != null || shards.isEmpty() : shards; | |||
| assert shards.isEmpty() == false : "cannot have an empty shard routing table"; | |||
There was a problem hiding this comment.
The same assertion is already added in the beginning of the method but without the message. Maybe we can merge them by moving the message to the earlier one.
There was a problem hiding this comment.
Oh sorry I forgot I added that for some local tests. Removed in 0e08cd5.
idegtiarenko
approved these changes
Feb 22, 2024
Yes good point, there's a few obvious ones, see 0e08cd5. |
DaveCTurner
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's only one remaining test that creates an empty
IndexShardRoutingTable. This commit fixes that, and then adds anassertion to enforce that all
IndexShardRoutingTableinstances includeat least a primary shard.