Fix default search timeout in watcher docs

[nielsbauman]

There are a couple of "default search timeout" settings:

• elasticsearch/x-pack/plugin/watcher/src/main/java/org/elasticsearch/xpack/watcher/WatcherService.java

  Line 99 in dceea61

  this.defaultSearchTimeout = settings.getAsTime("xpack.watcher.internal.ops.search.default_timeout", TimeValue.timeValueSeconds(30));

• elasticsearch/x-pack/plugin/watcher/src/main/java/org/elasticsearch/xpack/watcher/execution/TriggeredWatchStore.java

  Line 71 in dceea61

  this.defaultSearchTimeout = settings.getAsTime("xpack.watcher.internal.ops.search.default_timeout", TimeValue.timeValueSeconds(30));

These two do have a default of 30s, but they seem to be influencing other aspects of the watcher module.
The one that actually seems to be the Watcher search input default timeout setting is:

elasticsearch/x-pack/plugin/watcher/src/main/java/org/elasticsearch/xpack/watcher/input/search/SearchInputFactory.java

Line 36 in dceea61

this.defaultTimeout = settings.getAsTime("xpack.watcher.input.search.default_timeout", TimeValue.timeValueMinutes(1));

This seems to have been the case for a while already (the docs line and the default in the code haven't changed since 2017), so then the question becomes until what version we want to backport this (provided that my conclusion above is actually correct).

[github-actions]

Documentation preview:

• ✨ Changed pages

[elasticsearchmachine]

Pinging @elastic/es-docs (Team:Docs)

[elasticsearchmachine]

Pinging @elastic/es-data-management (Team:Data Management)

[masseyke]

I think you are right that the documentation needs to change to 1m. Given that this is pretty minor and no one has noticed for at least 7 years, I think we only need to put this in main and 7.17.x.
It looks like xpack.watcher.internal.ops.search.default_timeout is the timeout for querying the .watches index (in WatcherService) and the .triggered_watches index (in TriggeredWatchStore), so not related here. The name is a little odd since it's not the default timeout -- it is the timeout for those. But it doesn't seem worth changing that one now.

[masseyke]

It's also kind of odd that xpack.watcher.input.search.default_timeout is not documented -- our documentation just makes it sound like that default is hard-coded to 1m rather than coming from a setting.

[masseyke]

Looking in the old private x-pack repo, if the default value of xpack.watcher.input.search.default_timeout was null (which it was before the commit Niels references), then it would fall back on xpack.watcher.internal.ops.search.default_timeout, and in that instance the default of xpack.watcher.internal.ops.search.default_timeout was also 30s. That all changed in 6.0.0. So the documentation has been wrong for 6.5 years.

[elasticsearchmachine]

💚 Backport successful

Status	Branch	Result
✅	7.17