ESQL: Support ST_DISJOINT #107007
Merged
ESQL: Support ST_DISJOINT #107007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigtaverner
added
>enhancement
Team:Analytics
|
Hi @craigtaverner, I've created a changelog YAML for you. |
craigtaverner
force-pushed
the
st_disjoint
branch
from
f8def0f to
26e8141
Compare
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
craigtaverner
force-pushed
the
st_disjoint
branch
from
1ce06ef to
d455155
Compare
Initially based on ST_INTERSECTS
craigtaverner
force-pushed
the
st_disjoint
branch
from
d455155 to
e62c021
Compare
iverase
reviewed
Apr 8, 2024
| // Should never be null, but can be an empty geometry | ||
| return new MatchNoDocsQuery(); | ||
| // Should never be null, but could be an empty geometry | ||
| return new MatchNoDocsQuery("Empty geometry"); |
There was a problem hiding this comment.
Is this correct for disjoint?
iverase
requested changes
Apr 8, 2024
…ption In lucene code only LineString can be empty, but in Elasticsearch even that is not allowed, resulting in parsing errors. So we cannot get to this code in the lucene push-down and now throw an error instead. The tests now assert on the warnings. Note that for any predicate DISJOINT and INTERSECTS alike, the predicate fails, because the parsing error results in null, the function returns null, the predicate interprets this as false, and no documents match. This null-in-null-out rule means that DISJOINT and INTERSECTS give the same answer on invalid geometries.
iverase
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from the ESQL spatial query work already done:
We add the fourth and final of the four Lucene-backed spatial search predicates:
ST_DISJOINT. This is essentially the opposite ofST_INTERSECTSsuch that if two geometries intersect, they are not disjoint, and if they do not intersect, they are disjoint. The PostGIS documentation can be comared at https://postgis.net/docs/ST_Disjoint.html