Validate stats formatting in standard InternalStats constructor #107678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:Analytics
|
Hi @iverase, I've created a changelog YAML for you. |
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
💚 Backport successful
|
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Apr 24, 2024
…tic#107678) We want to validate stats formatting before we serialize to XContent, as chunked x-content serialization assumes that we don't throw exceptions at that point. It is not necessary to do it in the StreamInput constructor as this one has been serialise from an already checked object. This commit adds starts formatting validation to the standard InternalStats constructor.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 24, 2024
) (#107851) We want to validate stats formatting before we serialize to XContent, as chunked x-content serialization assumes that we don't throw exceptions at that point. It is not necessary to do it in the StreamInput constructor as this one has been serialise from an already checked object. This commit adds starts formatting validation to the standard InternalStats constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to validate stats formatting before we serialize to XContent, as chunked x-content serialization assumes that we
don't throw exceptions at that point.It is not necessary to do it in the StreamInput constructor as this one has been serialise from an already checked object.
This commit adds starts formatting validation to the standard InternalStats constructor.
fixes #107671