[Inference API] Use extractOptionalPositiveInteger instead of removeAsType in AzureAiStudioEmbeddingsServiceSettings #110366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…StudioEmbeddingsServiceSettings
timgrein
added
>non-issue
:ml
|
Pinging @elastic/ml-core (Team:ML) |
davidkyle
approved these changes
Jul 4, 2024
| * @return an <code>int</code> between <code>Integer.MIN_VALUE</code> and <code>-1</code> (inclusive) chosen uniformly at random. | ||
| */ | ||
| public static int randomNegativeInt() { | ||
| return randomInt() | Integer.MIN_VALUE; |
There was a problem hiding this comment.
Nice.
I was worried about the corner cases if randomInt returned 0 or MAX_VALUE but
0 | Integer.MIN_VALUE == Integer.MIN_VALUE
Integer.MAX_VALUE | Integer.MIN_VALUE == -1
|
@elasticmachine update branch |
…xtract-optional-positive-integer-instead-of-remove-as-type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same rationale as in #110278. Added explicit tests this time, will add them afterwards to the other two places I've already merged (I want to use
randomNegativeIntalso there, so waiting for this PR to merge first).