ESQL: Skip retrofitted tests #111019
Merged
ESQL: Skip retrofitted tests #111019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
alex-spies
force-pushed
the
fix-retrofitted-tests
branch
from
0418c1b to
ad22c98
Compare
alex-spies
added
>test
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
|
I ran the mixed cluster tests for 8.12.2, 8.13.4 and 8.14.2 multiple times to ensure nothing was missed - and derived the skips from this exercise. |
alex-spies
commented
Jul 18, 2024
| @@ -1947,8 +1947,7 @@ MIN(i):integer | a:keyword | b:integer | |||
| // end::multi-mv-group-result[] | |||
| ; | |||
|
|
|||
| statsByConstant | |||
| required_capability: stats_by_constant | |||
| statsByConstant#[skip:-8.14.1,reason:implemented in 8.14] | |||
There was a problem hiding this comment.
@fang-xing-esql instead of skipping based on the new capability we added, I thought we'll get better coverage if we skip based on the version from which this was first possible.
nik9000
approved these changes
Jul 18, 2024
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
alex-spies
added a commit
to alex-spies/elasticsearch
that referenced
this pull request
Jul 19, 2024
(cherry picked from commit 548aea5) # Conflicts: # muted-tests.yml # x-pack/plugin/esql/qa/testFixtures/src/main/resources/stats.csv-spec # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 19, 2024
ioanatia
pushed a commit
to ioanatia/elasticsearch
that referenced
this pull request
Jul 22, 2024
salvatore-campagna
pushed a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Jul 23, 2024
salvatore-campagna
pushed a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #110895
Fix #110950
Fix #110978
Some of our csv tests are failing on 8.11; they test functionality that was present back then, but was improved and fixed after 8.11.