Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: Unmute and fix Max/Min CSV tests with unsorted IPs #111149

Merged
merged 2 commits into from
Jul 22, 2024
+6 −19
Merged

ESQL: Unmute and fix Max/Min CSV tests with unsorted IPs #111149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34caf19
Fix CSV tests order on Max and Min IP cases
ivancea Jul 22, 2024
b1d6aba
Unmute tests
ivancea Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,6 @@ tests:
- class: org.elasticsearch.xpack.esql.spatial.SpatialPushDownGeoPointIT
method: testPushedDownQueriesSingleValue
issue: https://github.com/elastic/elasticsearch/issues/111084
- class: org.elasticsearch.xpack.esql.ccq.MultiClusterSpecIT
method: test {stats.MaxOfIpGrouping}
issue: https://github.com/elastic/elasticsearch/issues/111107
- class: org.elasticsearch.ingest.geoip.EnterpriseGeoIpDownloaderIT
method: testEnterpriseDownloaderTask
issue: https://github.com/elastic/elasticsearch/issues/111002
Expand All @@ -114,9 +111,6 @@ tests:
issue: https://github.com/elastic/elasticsearch/issues/110982
- class: org.elasticsearch.multi_node.GlobalCheckpointSyncActionIT
issue: https://github.com/elastic/elasticsearch/issues/111124
- class: org.elasticsearch.xpack.esql.ccq.MultiClusterSpecIT
method: test {stats.MinOfIpGrouping}
issue: https://github.com/elastic/elasticsearch/issues/111125
- class: org.elasticsearch.xpack.security.authz.store.NativePrivilegeStoreCacheTests
method: testGetPrivilegesUsesCache
issue: https://github.com/elastic/elasticsearch/issues/110788
Expand All @@ -126,15 +120,6 @@ tests:
- class: org.elasticsearch.cluster.PrevalidateShardPathIT
method: testCheckShards
issue: https://github.com/elastic/elasticsearch/issues/111134
- class: org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT
method: test {stats.MaxOfIpGrouping SYNC}
issue: https://github.com/elastic/elasticsearch/issues/111136
- class: org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT
method: test {stats.MinOfIpGrouping SYNC}
issue: https://github.com/elastic/elasticsearch/issues/111137
- class: org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT
method: test {stats.MinOfIpGrouping ASYNC}
issue: https://github.com/elastic/elasticsearch/issues/111138
- class: org.elasticsearch.packaging.test.DockerTests
method: test021InstallPlugin
issue: https://github.com/elastic/elasticsearch/issues/110343
Expand Down
10 changes: 6 additions & 4 deletions x-pack/plugin/esql/qa/testFixtures/src/main/resources/stats.csv-spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,13 @@ required_capability: agg_max_min_ip_support
from hosts
| eval x = ip0
| where host > "alpha"
| stats max(ip0), a = max(ip0), b = max(x), c = max(case(host == "beta", ip0, ip1)) by host;
| stats max(ip0), a = max(ip0), b = max(x), c = max(case(host == "beta", ip0, ip1)) by host
| sort host asc;

max(ip0):ip | a:ip | b:ip | c:ip | host:keyword
127.0.0.1 | 127.0.0.1 | 127.0.0.1 | 127.0.0.1 | beta
fe80::cae2:65ff:fece:feb9 | fe80::cae2:65ff:fece:feb9 | fe80::cae2:65ff:fece:feb9 | fe81::cae2:65ff:fece:feb9 | gamma
fe82::cae2:65ff:fece:fec0 | fe82::cae2:65ff:fece:fec0 | fe82::cae2:65ff:fece:fec0 | fe82::cae2:65ff:fece:fec0 | epsilon
fe80::cae2:65ff:fece:feb9 | fe80::cae2:65ff:fece:feb9 | fe80::cae2:65ff:fece:feb9 | fe81::cae2:65ff:fece:feb9 | gamma
;

minOfBooleanExpression
Expand Down Expand Up @@ -111,12 +112,13 @@ required_capability: agg_max_min_ip_support
from hosts
| eval x = ip0
| where host > "alpha"
| stats min(ip0), a = min(ip0), b = min(x), c = min(case(host == "beta", ip0, ip1)) by host;
| stats min(ip0), a = min(ip0), b = min(x), c = min(case(host == "beta", ip0, ip1)) by host
| sort host asc;

min(ip0):ip | a:ip | b:ip | c:ip | host:keyword
127.0.0.1 | 127.0.0.1 | 127.0.0.1 | 127.0.0.1 | beta
fe80::cae2:65ff:fece:feb9 | fe80::cae2:65ff:fece:feb9 | fe80::cae2:65ff:fece:feb9 | 127.0.0.3 | gamma
fe80::cae2:65ff:fece:feb9 | fe80::cae2:65ff:fece:feb9 | fe80::cae2:65ff:fece:feb9 | 127.0.0.1 | epsilon
fe80::cae2:65ff:fece:feb9 | fe80::cae2:65ff:fece:feb9 | fe80::cae2:65ff:fece:feb9 | 127.0.0.3 | gamma
;

maxOfShort
Expand Down