Fix doc test - enable ccs_telemetry feature on tests #113066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smalyshev
added
:Search Foundations/CCS
>test
elasticsearchmachine
added
the
Team:Search Foundations
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
mark-vieira
reviewed
Sep 17, 2024
docs/build.gradle
Outdated
| @@ -85,6 +85,7 @@ testClusters.matching { it.name == "yamlRestTest"}.configureEach { | |||
| keystorePassword 'keystore-password' | |||
| if (BuildParams.isSnapshotBuild() == false) { | |||
There was a problem hiding this comment.
I think this whole block can be removed since we already define the feature flags below. Not sure why this has been duplicated for this flag but it's not needed.
smalyshev
force-pushed
the
doc-test-ccs-feature
branch
from
2e10259
to
8c37dae
Compare
mark-vieira
approved these changes
Sep 17, 2024
|
@elasticmachine update branch |
💔 Backport failed
You can use sqren/backport to manually backport by running |
smalyshev
added a commit
to smalyshev/elasticsearch
that referenced
this pull request
Sep 18, 2024
(cherry picked from commit 2d1b67b) # Conflicts: # muted-tests.yml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 18, 2024
|
Backported manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112732