[8.x] Fix exception message when validating the name of tokenizer(edgeNGram) #113257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
elasticsearchmachine
added
needs:triage
YeonghyeonKO
force-pushed
the
fix/analysis-tokenizer-edgeNGram
branch
from
e1b8f24 to
36c2cf1
Compare
YeonghyeonKO
changed the title
|
@carlosdelest |
carlosdelest
added
>non-issue
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
elasticsearchmachine
removed
the
needs:triage
|
@elasticsearchmachine test this please |
|
@elasticmachine run elasticsearch-ci/packaging-tests-windows-sample |
|
@elasticsearchmachine update branch |
|
@elasticmachine update branch |
|
@elasticsearchmachine test this please |
|
@elasticmachine run elasticsearch-ci/part-1 |
|
@elasticmachine test this please |
|
@elasticmachine update branch |
|
@elasticmachine test this please |
carlosdelest
approved these changes
Sep 26, 2024
|
It took a while to pass CI on this. Thanks for contributing to Elastic @YeonghyeonKO ! |
|
@carlosdelest Thank you for reviewing my PR. It took quite long to pass elasticsearch-ci indeed haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
getTokenizersinCommonAnalysisPluginreturns IllegalArgumentException with the message:For IndexVersion 8.x,
edge_ngram(notedge_nGram) is the correct name referred as anedgeNGramtokenizer so I ask to change the word in this Pull Request. The PR could reduce confusion in defining edgeNGram tokenizers when statically mapping indices in Elasticsearch 8.x.After 9.x version, @javanna's PR had made the deprecation issue clear and already been merged into
mainbranch, so there is no problem.