Updated Date Range to Follow Documentation When Assuming Missing Values 8x #113872
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a review of the documentation here: https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-range-query.html. Our behavior at query and index time for date range queries was inconsistent.
This would lead to what was discovered here: #111484 where an indexed date_range field like the one shown below would not be returned by the exact same query shown below.
I attempted to fix this by changing the query parser to use DateMathParser which rounds appropriately to what's documented above. This changes missing information in date time values to be inline with the documentation often by 1 millisecond (such as the time information in the below example).
A few concerns worth discussing with this are where this should land in terms of releases and impacts to customer who may have assumptions about how date range has been working up to this point. Opening this as a discussion with some caution around putting it in until we get appropriate feedback.
query example